Convert user profile images into a standard cache
ClosedPublic
Actions

Authored by epriestley on Jun 5 2016, 1:00 AM.

Details

Reviewers

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults
T10078: Implement global readthrough cache pools

Commits

rP6f1053c206f1: Convert user profile images into a standard cache

Summary

Ref T4103. Ref T10078. This moves profile image caches to new usercache infrastructure.

These dirty automatically based on configuration and User properties, so add some stuff to make that happen.

This reduces the number of queries issued on every page by 1.

Test Plan

Browsed around, changed profile image, viewed as self, viewed as another user, verified no more query to pull this information on every page

Diff Detail

Repository

rP Phabricator

Branch

setting29

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12462
Build 15790: Run Core Tests
Build 15789: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	50 ms	PhabricatorAccessControlTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhabricatorAccessControlTestCase.php:261): Expect user 'normal' to be allowed access to 'Default'. ACTUAL VALUE
	0 ms	PhabricatorLocalTimeTestCase::Unknown Unit Message ("") EXCEPTION (PhabricatorDataNotAttachedException): Attempting to access attached data on PhabricatorUser (via getUserSetting()), but the data is not actually attached. Before accessing attachable data on an object, you must load and attach it. Data is normally attached by calling the corresponding needX() method on the Query class when the object is loaded. You can also call the corresponding attachX() method explicitly.
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 2 assertions passed.
		View Full Test Results (2 Failed · 322 Passed)

Event Timeline

epriestley updated this revision to Diff 38591.Jun 5 2016, 1:00 AM

epriestley retitled this revision from to Convert user profile images into a standard cache.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10078: Implement global readthrough cache pools, T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

Unit test failures?

Those failures are probably fixed in D16041, let me backport the fixes.

Oh, no, they're not directly related. Some unit tests try to build/access users in weird ways that don't work with some of the cache stuff. I'll sort it out in the morning.

epriestley mentioned this in D16042: Make caches misses throw by default intead of inline-generating.Jun 5 2016, 1:39 PM