Page MenuHomePhabricator

Modularize transaction/comment indexing in the FulltextEngine
ClosedPublic

Authored by epriestley on Dec 21 2015, 3:23 PM.
Tags
None
Referenced Files
F13429904: D14837.diff
Wed, Jul 10, 4:43 AM
F13391635: D14837.diff
Tue, Jul 2, 10:45 AM
F13381744: D14837.diff
Sun, Jun 30, 2:42 AM
F13361397: D14837.diff
Tue, Jun 25, 2:13 PM
F13359451: D14837.diff
Tue, Jun 25, 9:40 AM
F13352202: D14837.id35892.diff
Sun, Jun 23, 11:56 AM
F13331152: D14837.diff
Mon, Jun 17, 5:36 AM
F13318428: D14837.diff
Jun 13 2024, 11:03 AM
Subscribers
None

Details

Summary

Ref T9979. This is currently hard-coded but can be done in a generic way.

This has one minor behavioral changes: answer text is no longer included in the question text index in Ponder. I'm not planning to accommodate that for now since I don't want to dig this hole any deeper than I already have. This behavior should be different anyway (e.g., index the answer, then show the question in the results or something).

Test Plan
  • Put a unique word in a Maniphest comment.
  • Searched for the word.
  • Found the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize transaction/comment indexing in the FulltextEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.