Page MenuHomePhabricator

Modularize transaction/comment indexing in the FulltextEngine
ClosedPublic

Authored by epriestley on Dec 21 2015, 3:23 PM.
Tags
None
Referenced Files
F11515714: D14837.diff
Tue, Jan 31, 2:47 AM
Unknown Object (File)
Sat, Jan 14, 6:05 PM
Unknown Object (File)
Sat, Jan 14, 6:04 PM
Unknown Object (File)
Sat, Jan 14, 5:53 PM
Unknown Object (File)
Wed, Jan 4, 5:47 AM
Unknown Object (File)
Dec 11 2022, 1:01 AM
Unknown Object (File)
Dec 11 2022, 1:01 AM
Unknown Object (File)
Dec 11 2022, 1:01 AM
Subscribers
None

Details

Summary

Ref T9979. This is currently hard-coded but can be done in a generic way.

This has one minor behavioral changes: answer text is no longer included in the question text index in Ponder. I'm not planning to accommodate that for now since I don't want to dig this hole any deeper than I already have. This behavior should be different anyway (e.g., index the answer, then show the question in the results or something).

Test Plan
  • Put a unique word in a Maniphest comment.
  • Searched for the word.
  • Found the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize transaction/comment indexing in the FulltextEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.