Page MenuHomePhabricator

Modularize transaction/comment indexing in the FulltextEngine

Authored by epriestley on Dec 21 2015, 3:23 PM.
Referenced Files
Unknown Object (File)
Mon, Mar 20, 1:11 PM
Unknown Object (File)
Thu, Mar 16, 1:07 AM
Unknown Object (File)
Thu, Mar 2, 12:24 AM
Unknown Object (File)
Wed, Mar 1, 4:48 AM
Unknown Object (File)
Wed, Mar 1, 4:48 AM
Unknown Object (File)
Wed, Mar 1, 4:48 AM
Unknown Object (File)
Feb 13 2023, 10:34 AM
Unknown Object (File)
Feb 8 2023, 1:28 AM



Ref T9979. This is currently hard-coded but can be done in a generic way.

This has one minor behavioral changes: answer text is no longer included in the question text index in Ponder. I'm not planning to accommodate that for now since I don't want to dig this hole any deeper than I already have. This behavior should be different anyway (e.g., index the answer, then show the question in the results or something).

Test Plan
  • Put a unique word in a Maniphest comment.
  • Searched for the word.
  • Found the task.

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 9684
Build 11611: Run Core Tests
Build 11610: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize transaction/comment indexing in the FulltextEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.