Page MenuHomePhabricator

Modularize transaction/comment indexing in the FulltextEngine
ClosedPublic

Authored by epriestley on Dec 21 2015, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 28, 1:35 PM
Unknown Object (File)
Fri, Jun 27, 2:54 PM
Unknown Object (File)
Mon, Jun 16, 6:40 PM
Unknown Object (File)
Jun 5 2025, 3:24 PM
Unknown Object (File)
Jun 1 2025, 9:05 PM
Unknown Object (File)
May 28 2025, 3:13 PM
Unknown Object (File)
May 27 2025, 3:23 PM
Unknown Object (File)
May 25 2025, 6:46 AM
Subscribers
None

Details

Summary

Ref T9979. This is currently hard-coded but can be done in a generic way.

This has one minor behavioral changes: answer text is no longer included in the question text index in Ponder. I'm not planning to accommodate that for now since I don't want to dig this hole any deeper than I already have. This behavior should be different anyway (e.g., index the answer, then show the question in the results or something).

Test Plan
  • Put a unique word in a Maniphest comment.
  • Searched for the word.
  • Found the task.

Diff Detail

Repository
rP Phabricator
Branch
index4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9684
Build 11611: Run Core Tests
Build 11610: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize transaction/comment indexing in the FulltextEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.