Page MenuHomePhabricator
Differential D14577

Improve error handling in `arc install-certificate`
ClosedPublic
Actions

Authored by epriestley on Nov 27 2015, 4:37 PM.
Tags
None
Referenced Files
F15524080: D14577.id35269.diff
Mon, Apr 21, 5:49 AM
F15513933: D14577.id35270.diff
Thu, Apr 17, 11:00 PM
F15513798: D14577.id.diff
Thu, Apr 17, 9:56 PM
F15506760: D14577.diff
Tue, Apr 15, 1:59 PM
F15451552: D14577.diff
Fri, Mar 28, 10:40 PM
F15415832: D14577.id35270.diff
Mar 20 2025, 7:58 AM
F15397808: D14577.id.diff
Mar 16 2025, 10:23 PM
F15388864: D14577.id35269.diff
Mar 15 2025, 4:33 AM
View All Files
Subscribers
None

Details

Reviewers
joshuaspence
chad
Maniphest Tasks
T9858: Cryptic error message when running `arc install certificate`
Commits
rARC4f1141d0c59b: Improve error handling in `arc install-certificate`
Summary

Fixes T9858. Reasonable typos and misunderstandings currently produce very confusing error messages.

Test Plan
$ arc install certificate
Usage Exception: Server URI "certificate" must include a protocol and domain. It should be in the form "https://phabricator.example.com/".
  • Also used a good URI.
  • Also used no URI.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35269.Nov 27 2015, 4:37 PM
epriestley retitled this revision from to Improve error handling in `arc install-certificate`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
epriestley added a task: T9858: Cryptic error message when running `arc install certificate`.
chad accepted this revision.Nov 27 2015, 5:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 27 2015, 5:05 PM
Closed by commit rARC4f1141d0c59b: Improve error handling in `arc install-certificate` (authored by epriestley, committed by epriestley). · Explain WhyNov 27 2015, 5:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
workflow/
23 lines

Diff 35270

View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Loading...
Phabricator · Built by Phacility