Page MenuHomePhabricator
Differential D14468

Make Herald rules subscribable
ClosedPublic
Actions

Authored by joshuaspence on Nov 12 2015, 8:59 AM.
Tags
None
Referenced Files
F18087487: D14468.diff
Wed, Aug 6, 4:11 AM
F17955961: D14468.id35067.diff
Fri, Aug 1, 5:12 AM
F17953844: D14468.id35058.diff
Fri, Aug 1, 3:32 AM
F17872408: D14468.id.diff
Mon, Jul 28, 4:43 PM
F17854296: D14468.diff
Sun, Jul 27, 2:54 PM
Unknown Object (File)
Jun 1 2025, 12:21 PM
Unknown Object (File)
Apr 27 2025, 5:38 PM
Unknown Object (File)
Apr 20 2025, 3:50 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9757: Add subscribers to Herald
Commits
Restricted Diffusion Commit
rP26a235ab8a18: Make Herald rules subscribable
Summary

Fixes T9757.

Test Plan

Created a Herald rule and then subscribed to it with a different account.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8868
Build 10371: Run Core Tests
Build 10370: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 34988.Nov 12 2015, 8:59 AM
joshuaspence retitled this revision from to Make Herald rules subscribbable.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T9757: Add subscribers to Herald.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 12 2015, 8:59 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley requested changes to this revision.Nov 12 2015, 6:42 PM
epriestley edited edge metadata.

One minor quibble about auto-subscribe -- does that make sense?

src/applications/herald/storage/HeraldRule.php
328

This is right for personal rules, but I don't think we should auto-subscribe the author for object/global rules?

This revision now requires changes to proceed.Nov 12 2015, 6:42 PM
joshuaspence added inline comments.Nov 12 2015, 7:48 PM
src/applications/herald/storage/HeraldRule.php
328

Agreed. I realized this later but didn't get around to updating the diff.

chad retitled this revision from Make Herald rules subscribbable to Make Herald rules subscribable.Nov 12 2015, 7:52 PM
chad edited edge metadata.
joshuaspence updated this revision to Diff 35058.Nov 16 2015, 11:57 AM
joshuaspence edited edge metadata.
joshuaspence marked 2 inline comments as done.

Only auto-subscribe personal rules

epriestley accepted this revision.Nov 16 2015, 4:42 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2015, 4:42 PM
Closed by commit rP26a235ab8a18: Make Herald rules subscribable (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 16 2015, 7:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
16 lines
src/
1 line
applications/
herald/
storage/
20 lines
1 line

Diff 35058

View Options

resources/sql/autopatches/20151112.herald.edge.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
View Options

src/applications/herald/storage/HeraldSchemaSpec.php

Loading...
Phabricator · Built by Phacility