Differential D14468

Make Herald rules subscribable
ClosedPublic
Actions

Authored by joshuaspence on Nov 12 2015, 8:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 1, 12:21 PM

	Unknown Object (File)
	Apr 27 2025, 5:38 PM

	Unknown Object (File)
	Apr 20 2025, 3:50 PM

	Unknown Object (File)
	Apr 20 2025, 3:50 PM

	Unknown Object (File)
	Apr 20 2025, 3:50 PM

	Unknown Object (File)
	Apr 20 2025, 3:50 PM

	Unknown Object (File)
	Apr 13 2025, 11:16 AM

	Unknown Object (File)
	Apr 12 2025, 11:14 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9757: Add subscribers to Herald

Commits

Restricted Diffusion Commit
rP26a235ab8a18: Make Herald rules subscribable

Summary

Fixes T9757.

Test Plan

Created a Herald rule and then subscribed to it with a different account.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 8798
Build 10256: Run Core Tests
Build 10255: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,431 ms	PhabricatorLibraryTestCase::Unknown Unit Message ("")
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("")
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 290 Passed)

Event Timeline

joshuaspence updated this revision to Diff 34988.Nov 12 2015, 8:59 AM

joshuaspence retitled this revision from to Make Herald rules subscribbable.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T9757: Add subscribers to Herald.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 12 2015, 8:59 AM

Herald added a subscriber: Korvin. · View Herald Transcript

One minor quibble about auto-subscribe -- does that make sense?

src/applications/herald/storage/HeraldRule.php
328	This is right for personal rules, but I don't think we should auto-subscribe the author for object/global rules?

This revision now requires changes to proceed.Nov 12 2015, 6:42 PM

joshuaspence added inline comments.Nov 12 2015, 7:48 PM

src/applications/herald/storage/HeraldRule.php
328	Agreed. I realized this later but didn't get around to updating the diff.

chad retitled this revision from Make Herald rules subscribbable to Make Herald rules subscribable.Nov 12 2015, 7:52 PM

chad edited edge metadata.

Only auto-subscribe personal rules

epriestley accepted this revision.Nov 16 2015, 4:42 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 16 2015, 4:42 PM

Closed by commit rP26a235ab8a18: Make Herald rules subscribable (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 16 2015, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20151112.herald.edge.sql

16 lines

src/

applications/

herald/

storage/

20 lines

HeraldSchemaSpec.php

1 line

Diff 34988

resources/sql/autopatches/20151112.herald.edge.sql

Loading...

src/applications/herald/storage/HeraldRule.php

Loading...

src/applications/herald/storage/HeraldSchemaSpec.php

Loading...