Fixes T9757.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9757: Add subscribers to Herald
- Commits
- Restricted Diffusion Commit
rP26a235ab8a18: Make Herald rules subscribable
Created a Herald rule and then subscribed to it with a different account.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
One minor quibble about auto-subscribe -- does that make sense?
src/applications/herald/storage/HeraldRule.php | ||
---|---|---|
328 | This is right for personal rules, but I don't think we should auto-subscribe the author for object/global rules? |
src/applications/herald/storage/HeraldRule.php | ||
---|---|---|
328 | Agreed. I realized this later but didn't get around to updating the diff. |