The unit engine requires the use of the junit_formatter to be configured properly.
The linter depends on the development version of dogma
Details
Details
- Reviewers
joshuaspence - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9796: Add linting support for Elixir
T9797: Add unit testing support for Elixir - Required Signatures
L28 Phacility Individual Contributor License Agreement
- Configure "unit.engine": "ExunitTestEngine" in .arcconfig
- Configure "type": "elixirdogma" as a linter in .arclint
- Configure ExUnit to use the JUnitFormatter as documented at https://github.com/victorolinasc/junit-formatter
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- tb/elixir-lint-unit
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8841 Build 10323: arc lint + arc unit
Event Timeline
Comment Actions
I should note that I'm not used to working with PHP, so feel free to criticize. I tried to stay close to the other unit and lint classes.
Comment Actions
As per https://secure.phabricator.com/book/phabcontrib/article/contributing_code/, you should file a task for this change before you can get any attention.
The linter depends on the development version of dogma
Does this mean it is likely to break in a month?
- Configure ExUnit to use the JUnitFormatter as documented at https://github.com/victorolinasc/junit-formatter
Can you put this into the test runner code, so that configuration is easier for users?
Comment Actions
Thanks for the pointer, I created the appropriate tasks: T9796 and T9797
Does this mean it is likely to break in a month?
Well, it means a developer must use the HEAD of the git repository instead of the latest tagged version.
Can you put this into the test runner code, so that configuration is easier for users?
It is already in the file's documentation, what else are you referring to?
Comment Actions
Does this mean it is likely to break in a month?
Well, it means a developer must use the HEAD of the git repository instead of the latest tagged version.
As in, the installation instructions are "clone HEAD of some repo"?
This might sound strange, but these instructions are more than I'd expect users to handle (Users are repeatedly baffled by "run 'npm install jshint'". I wish I was exaggerating).
Also, if there's no official version that supports this code, they can decide to change their api, making stop working.
Can you put this into the test runner code, so that configuration is easier for users?
It is already in the file's documentation, what else are you referring to?
I mean, code the engine/linter in such a way that the users don't need to read documentation. Adding flags, for example.
I think you'll need to wait for the Elixir/dogma code to stabilize before getting any serious consideration for this feature.
Comment Actions
Interesting. I will add some additional info regarding this issue to the instructions.
Can you put this into the test runner code, so that configuration is easier for users?
It is already in the file's documentation, what else are you referring to?
I mean, code the engine/linter in such a way that the users don't need to read documentation. Adding flags, for example.
This wouldn't be feasable since using the junit formatter requires multiple changes in a project's source code, which if being done magically by the unit engine would need to be kept in sync with whatever changes in the formatter itself.
I think you'll need to wait for the Elixir/dogma code to stabilize before getting any serious consideration for this feature.
Fine by me. I work off a working fork in the meantime. Elixir is stable, so I only see dogma as the moving target.