Differential D14256

Update metamta for handleRequest
ClosedPublic
Actions

Authored by chad on Oct 12 2015, 6:44 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8628: Modernize AphrontControllers to implement handleRequest

Commits

Restricted Diffusion Commit
rPdac16264e401: Update metamta for handleRequest

Summary

Updates metamta for handleRequest

Test Plan

Unable to test this, but looks safe?

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34419.Oct 12 2015, 6:44 PM

chad retitled this revision from to Update metamta for handleRequest.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 12 2015, 6:44 PM

Yeah, this is super hard to test locally. Changes look fine and you can test the Mailgun half by sending mail to this install after I push it.

src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php
30–31	You could nuke this, I think.
src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php
13–14	And this.

This revision is now accepted and ready to land.Oct 12 2015, 6:49 PM

Closed by commit rPdac16264e401: Update metamta for handleRequest (authored by chad, committed by chad). · Explain WhyOct 12 2015, 7:02 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.Oct 18 2015, 6:58 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

controller/

PhabricatorMetaMTAMailgunReceiveController.php

3 lines

PhabricatorMetaMTASendGridReceiveController.php

4 lines

Diff 34422

View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php