Page MenuHomePhabricator
Differential D14256

Update metamta for handleRequest
ClosedPublic
Actions

Authored by chad on Oct 12 2015, 6:44 PM.
Tags
None
Referenced Files
F14416047: D14256.diff
Tue, Dec 24, 8:30 PM
Unknown Object (File)
Fri, Dec 20, 7:50 AM
Unknown Object (File)
Thu, Dec 19, 8:44 PM
Unknown Object (File)
Tue, Dec 10, 9:01 PM
Unknown Object (File)
Sat, Dec 7, 4:45 AM
Unknown Object (File)
Nov 20 2024, 8:28 PM
Unknown Object (File)
Nov 20 2024, 8:28 PM
Unknown Object (File)
Nov 18 2024, 6:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rPdac16264e401: Update metamta for handleRequest
Summary

Updates metamta for handleRequest

Test Plan

Unable to test this, but looks safe?

Diff Detail

Repository
rP Phabricator
Branch
metameta-proc
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8234
Build 9420: Run Core Tests
Build 9419: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34419.Oct 12 2015, 6:44 PM
chad retitled this revision from to Update metamta for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 12 2015, 6:44 PM
epriestley accepted this revision.Oct 12 2015, 6:49 PM
epriestley edited edge metadata.

Yeah, this is super hard to test locally. Changes look fine and you can test the Mailgun half by sending mail to this install after I push it.

src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php
31

You could nuke this, I think.

src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php
15

And this.

This revision is now accepted and ready to land.Oct 12 2015, 6:49 PM
Closed by commit rPdac16264e401: Update metamta for handleRequest (authored by chad, committed by chad). · Explain WhyOct 12 2015, 7:02 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.Oct 18 2015, 6:58 AM

Revision Contents
Changeset List

Diff 34419

View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailgunReceiveController.php

Loading...
View Options

src/applications/metamta/controller/PhabricatorMetaMTASendGridReceiveController.php

Loading...
Phabricator · Built by Phacility