Page MenuHomePhabricator

Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract
ClosedPublic

Authored by joshuaspence on Sep 6 2015, 3:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 9:24 PM
Unknown Object (File)
Mon, Dec 9, 1:26 PM
Unknown Object (File)
Fri, Nov 29, 6:53 AM
Unknown Object (File)
Thu, Nov 28, 9:28 PM
Unknown Object (File)
Tue, Nov 26, 5:45 PM
Unknown Object (File)
Fri, Nov 22, 9:24 AM
Unknown Object (File)
Nov 18 2024, 12:12 AM
Unknown Object (File)
Nov 14 2024, 7:38 AM
Subscribers

Details

Summary

Fixes T9625. As explained in a TODO comment, seems reasonable enough.

Test Plan

Unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Mark `PhabricatorPHIDType::getPHIDTypeApplicationClass()` as abstract.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

(I vaguely wonder if we should have a PhabricatorWhateverApplication::APPCONST sort of constant, mostly to get better static analyzability, but that's easy to add later.)

This revision is now accepted and ready to land.Sep 6 2015, 2:58 PM
This revision was automatically updated to reflect the committed changes.