Page MenuHomePhabricator

Modularize generation of supplemental login messages
ClosedPublic

Authored by epriestley on Sep 4 2015, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 3:45 AM
Unknown Object (File)
Sat, Mar 16, 8:05 AM
Unknown Object (File)
Sat, Mar 16, 8:05 AM
Unknown Object (File)
Sat, Mar 16, 8:05 AM
Unknown Object (File)
Sun, Mar 10, 6:11 PM
Unknown Object (File)
Feb 8 2024, 11:11 AM
Unknown Object (File)
Feb 3 2024, 6:32 AM
Unknown Object (File)
Jan 29 2024, 1:26 PM
Subscribers
None

Details

Summary

Ref T9346. This mostly allows us to give users additional advice based on which instance they are trying to log in to in the Phacility cluster.

It's also slightly more flexible than auth.login-message was, and maybe we'll add some more hooks here eventually.

This feels like it's a sidegrade in complexity rather than really an improvement, but not too terrible.

Test Plan
  • Wrote the custom handler in T9346 to replicate old config functionality.
  • Wrote a smart handler for Phacility that can provide context-sensitive messages based on which OAuth client you're trying to use.

See new message box at top (implementation in next diff):

Screen Shot 2015-09-04 at 9.25.34 AM.png (1×1 px, 163 KB)

Diff Detail

Repository
rP Phabricator
Branch
authm1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7912
Build 8853: [Placeholder Plan] Wait for 30 Seconds
Build 8852: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize generation of supplemental login messages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a child revision: Restricted Differential Revision.Sep 4 2015, 4:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2015, 5:25 PM
This revision was automatically updated to reflect the committed changes.