HomePhabricator

Shuffle various parts of the config edit UI around

Description

Shuffle various parts of the config edit UI around

Summary:
Fixes T9339.

  • Don't show edit control for locked config at all.
  • Don't show a "Cancel" button either.
  • Change "Value" label to "Database Value" for non-custom config.
  • Highlight effective value.
  • Move examples under current state.
  • Tweak some formatting.

Test Plan:

Screen Shot 2015-09-03 at 11.57.48 AM.png (884×1 px, 168 KB)

Reviewers: chad, avivey

Reviewed By: chad, avivey

Subscribers: avivey

Maniphest Tasks: T9339

Differential Revision: https://secure.phabricator.com/D14054

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Sep 3 2015, 7:15 PM
Reviewer
chad
Differential Revision
D14054: Shuffle various parts of the config edit UI around
Parents
rP29399849c0ed: Scroll on overflow of property list (mobile)
Branches
Unknown
Tags
Unknown
Tasks
T9339: Config Edit "Value" field is confusing