Page MenuHomePhabricator

Modularize generation of supplemental login messages
ClosedPublic

Authored by epriestley on Sep 4 2015, 4:30 PM.

Details

Summary

Ref T9346. This mostly allows us to give users additional advice based on which instance they are trying to log in to in the Phacility cluster.

It's also slightly more flexible than auth.login-message was, and maybe we'll add some more hooks here eventually.

This feels like it's a sidegrade in complexity rather than really an improvement, but not too terrible.

Test Plan
  • Wrote the custom handler in T9346 to replicate old config functionality.
  • Wrote a smart handler for Phacility that can provide context-sensitive messages based on which OAuth client you're trying to use.

See new message box at top (implementation in next diff):

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Modularize generation of supplemental login messages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a child revision: Restricted Differential Revision.Sep 4 2015, 4:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2015, 5:25 PM
This revision was automatically updated to reflect the committed changes.