Page MenuHomePhabricator
Differential D13987

Minor tidying of XHPAST code
ClosedPublic
Actions

Authored by joshuaspence on Aug 24 2015, 11:50 AM.
Tags
None
Referenced Files
F13049002: D13987.id.diff
Fri, Apr 19, 12:22 AM
Unknown Object (File)
Thu, Apr 11, 6:54 PM
Unknown Object (File)
Wed, Apr 10, 1:55 PM
Unknown Object (File)
Sat, Apr 6, 10:39 PM
Unknown Object (File)
Wed, Apr 3, 10:55 AM
Unknown Object (File)
Wed, Apr 3, 10:55 AM
Unknown Object (File)
Wed, Apr 3, 10:55 AM
Unknown Object (File)
Wed, Apr 3, 10:55 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU610ca9eba906: Minor tidying of XHPAST code
Summary

Fix a few linter violations in XHPAST source code and modify a bunch of code for consistency.

Test Plan

Ran arc unit --everything in rARC, rPHU and rP.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33765.Aug 24 2015, 11:50 AM
joshuaspence retitled this revision from to Minor tidying of XHPAST code.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 24 2015, 11:50 AM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley requested changes to this revision.Aug 24 2015, 5:12 PM
epriestley added a reviewer: epriestley.

Just kicking this back until it's not WIP.

This revision now requires changes to proceed.Aug 24 2015, 5:12 PM
joshuaspence updated this revision to Diff 33838.Aug 27 2015, 1:34 PM
joshuaspence edited edge metadata.

Further progress

Herald added a subscriber: Korvin. · View Herald TranscriptAug 27 2015, 1:34 PM
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM
joshuaspence updated this revision to Diff 34888.Nov 8 2015, 10:11 AM
joshuaspence edited edge metadata.

Rebase

joshuaspence updated this revision to Diff 34889.Nov 8 2015, 10:25 AM

Fix a few more linter violations

joshuaspence updated this object.Nov 8 2015, 10:51 AM
joshuaspence edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Nov 8 2015, 2:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2015, 2:15 PM
Closed by commit rPHU610ca9eba906: Minor tidying of XHPAST code (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 8 2015, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
support/
xhpast/
10 lines
41 lines
54 lines
2 lines
1614 lines
28 lines
2 lines
46331 lines
19 lines

Diff 34904

View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/astnode.hpp

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.hpp

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility