Page MenuHomePhabricator

Minor tidying of XHPAST code
ClosedPublic

Authored by joshuaspence on Aug 24 2015, 11:50 AM.

Details

Summary

Fix a few linter violations in XHPAST source code and modify a bunch of code for consistency.

Test Plan

Ran arc unit --everything in rARC, rPHU and rP.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7771
Build 8574: [Placeholder Plan] Wait for 30 Seconds
Build 8573: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Minor tidying of XHPAST code.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Just kicking this back until it's not WIP.

This revision now requires changes to proceed.Aug 24 2015, 5:12 PM
joshuaspence edited edge metadata.

Further progress

Fix a few more linter violations

joshuaspence edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2015, 2:15 PM
This revision was automatically updated to reflect the committed changes.