Page MenuHomePhabricator

Remove flex and bison debug flags
ClosedPublic

Authored by joshuaspence on Aug 23 2015, 2:06 AM.

Details

Summary

Remove --debug from flex and bison unless compiling with DEBUG defined.

Test Plan

Ran arc lint --everything --never-apply-patches --xprofile=profile.json in rP. Compared before and after.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsupport/xhpast/Makefile:6TXT2Tab Literal
Unit
No Test Coverage
Build Status
Buildable 7727
Build 8487: [Placeholder Plan] Wait for 30 Seconds
Build 8486: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Remove flex and bison debug flags.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
epriestley added inline comments.
support/xhpast/Makefile
3

CPPFLAGS also always gets -Wall I think?

This revision is now accepted and ready to land.Aug 23 2015, 2:05 PM
This revision was automatically updated to reflect the committed changes.