Differential D13935
Improve the "self member reference" linter rule Authored by joshuaspence on Aug 19 2015, 2:56 AM. Tags None Referenced Files
Subscribers
Details
Extends ArcanistSelfMemberReferenceXHPASTLinterRule to warn about the use of a hardcoded class name instead of self when instantiating a class. Arguably, we should maybe rename the linter rule from ArcanistSelfMemberReferenceXHPASTLinterRule to ArcanistSelfUsageXHPASTLinterRule, or even maybe split this rule into three separate rules:
Added to existing test cases.
Diff Detail
Event TimelineComment Actions This construction looks a little bizarre to me, but it seems reasonable to adopt given that we've adopted the member rule, I suppose. Comment Actions The more I thought about this the more I have come to favor splitting this rule into three smaller rules. Without doing this, it is impossible to customize the severities individually. Are you supporting of this idea? Comment Actions Yeah, I think that's reasonable. This one definitely looks a little more bizarre than the others. Comment Actions Wanted to get a pair of eyes on the change I made to ArcanistKeywordCasingXHPASTLinterRule. |