Paths

Table of Contentst

Diffusion Arcanist 581829a99ee8

Write a linter rule for `$this` reassignment
581829a99ee8
Actions

Description

Write a linter rule for $this reassignment

Summary: Re-assigning $this is an invalid PHP construct, see https://3v4l.org/TauX9.

Test Plan: Added unit tests.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14514

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Nov 19 2015, 7:51 PM

Reviewer

Blessed Reviewers

Differential Revision

D14514: Write a linter rule for `$this` reassignment

Parents

rARC426d535b13d7: Fix PHP compatibility linter after improvements to parsing of `use` statements

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8940
Build 10488: Run Core Tests

Event Timeline

joshuaspence committed rARC581829a99ee8: Write a linter rule for `$this` reassignment (authored by joshuaspence).Nov 19 2015, 7:50 PM

Harbormaster completed building B8940: rARC581829a99ee8: Write a linter rule for `$this` reassignment.Nov 19 2015, 7:52 PM

Changes (6)

Path

Size

src/

__phutil_library_map__.php

lint/

linter/

xhpast/

rules/

ArcanistThisReassignmentXHPASTLinterRule.php

__tests__/

ArcanistThisReassignmentXHPASTLinterRuleTestCase.php

this-reassignment

	this-reassignment/
	unexpected-return-value/

	class.lint-test
	empty-return.lint-test

	xhpast/	rules/	__tests__/	this-reassignment/
			__tests__/	xhpast/

	this.lint-test
	syntax-error.lint-test

rARC581829a99ee8

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/rules/ArcanistThisReassignmentXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistThisReassignmentXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/this-reassignment/class.lint-test

View Options

src/lint/linter/xhpast/rules/tests/this-reassignment/this.lint-test

Write a linter rule for `$this` reassignment581829a99ee8Actions

Description

Details

Event Timeline

Changes (6)

rARC581829a99ee8

src/__phutil_library_map__.php

src/lint/linter/xhpast/rules/ArcanistThisReassignmentXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistThisReassignmentXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/this-reassignment/class.lint-test

src/lint/linter/xhpast/rules/__tests__/this-reassignment/this.lint-test

Write a linter rule for `$this` reassignment
581829a99ee8
Actions

src/lint/linter/xhpast/rules/tests/ArcanistThisReassignmentXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/this-reassignment/class.lint-test

src/lint/linter/xhpast/rules/tests/this-reassignment/this.lint-test