Differential D13918

Fix an issue with Table of Contents construction for copied files
ClosedPublic
Actions

Authored by epriestley on Aug 17 2015, 12:49 AM.

Details

Reviewers

chad

Maniphest Tasks

T9201: Unhandled Exception ("InvalidArgumentException") on random Differential

Commits

Restricted Diffusion Commit
rPcfd134897501: Fix an issue with Table of Contents construction for copied files

Summary

Ref T9201.

Test Plan

Inspection.

Diff Detail

Repository

rP Phabricator

Branch

toc1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7655
Build 8348: [Placeholder Plan] Wait for 30 Seconds
Build 8347: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33587.Aug 17 2015, 12:49 AM

epriestley retitled this revision from to Fix an issue with Table of Contents construction for copied files.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9201: Unhandled Exception ("InvalidArgumentException") on random Differential.

chad accepted this revision.Aug 17 2015, 12:49 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 17 2015, 12:49 AM

i really should be able to catch these in review. :(

This one might have been catchable but was pretty tricky to spot.

And I definitely wouldn't have caught D13919 as a reviewer.

Closed by commit rPcfd134897501: Fix an issue with Table of Contents construction for copied files (authored by epriestley, committed by epriestley). · Explain WhyAug 17 2015, 12:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

view/

PHUIDiffTableOfContentsItemView.php

2 lines

Diff 33587

View Options

src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php

Fix an issue with Table of Contents construction for copied filesClosedPublicActions