Page MenuHomePhabricator
Differential D13855

Automatically use the configuration driven unit test engine
ClosedPublic
Actions

Authored by joshuaspence on Aug 10 2015, 9:28 PM.
Tags
None
Referenced Files
F14072971: D13855.id33458.diff
Wed, Nov 20, 10:22 PM
Unknown Object (File)
Tue, Nov 19, 1:07 PM
Unknown Object (File)
Tue, Nov 12, 10:00 PM
Unknown Object (File)
Mon, Nov 11, 5:58 AM
Unknown Object (File)
Mon, Nov 11, 5:58 AM
Unknown Object (File)
Mon, Nov 11, 5:58 AM
Unknown Object (File)
Mon, Nov 11, 5:58 AM
Unknown Object (File)
Thu, Nov 7, 3:51 AM
View All Files
Subscribers
Korvin
Tokens
"Yellow Medal" token, awarded by avivey."Love" token, awarded by hach-que.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5568: Support `.arcunit`, similar to `.arclint`
Commits
rARCe4caf1a7d94f: Automatically use the configuration driven unit test engine
Summary

Ref T5568. Use the ArcanistConfigurationDrivenUnitTestEngine automatically, if an .arcunit file exists. This behavior mimics the auto-detection for the configuration driven lint engine.

Test Plan

Ran through the following scenarios:

  • Ran arc unit and saw unit tests execute.
  • Ran arc unit --engine PhutilUnitTestEngine
  • Remove the .arcunit file and ran arc unit... got an exception.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33458.Aug 10 2015, 9:28 PM
joshuaspence retitled this revision from to Automatically use the configuration driven unit test engine.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5568: Support `.arcunit`, similar to `.arclint`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 10 2015, 9:28 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence added a child revision: D13851: Use the configuration driven unit test engine.Aug 10 2015, 9:29 PM
joshuaspence added a child revision: D13853: Use the configuration driven unit test engine.
epriestley accepted this revision.Aug 10 2015, 9:30 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/workflow/ArcanistWorkflow.php
1920

"lint" -> "unit"

This revision is now accepted and ready to land.Aug 10 2015, 9:30 PM
Closed by commit rARCe4caf1a7d94f: Automatically use the configuration driven unit test engine (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 10 2015, 9:56 PM
This revision was automatically updated to reflect the committed changes.
hach-que awarded a token.Aug 11 2015, 4:18 AM
avivey awarded a token.Aug 11 2015, 9:40 AM

Revision Contents
Changeset List

PathSize
1 line
src/
workflow/
26 lines
53 lines

Diff 33465

View Options

.arcconfig

Loading...
View Options

src/workflow/ArcanistUnitWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility