Page MenuHomePhabricator

Use the configuration driven unit test engine
ClosedPublic

Authored by joshuaspence on Aug 10 2015, 9:04 PM.
Tags
None
Referenced Files
F10891297: D13853.id33460.diff
Sun, Jul 3, 1:20 PM
F10891293: D13853.id33448.diff
Sun, Jul 3, 1:20 PM
F10891290: D13853.id.diff
Sun, Jul 3, 1:20 PM
Unknown Object (File)
Wed, Jun 29, 12:49 PM
Unknown Object (File)
Tue, Jun 28, 9:52 AM
Unknown Object (File)
Sat, Jun 25, 9:41 AM
Unknown Object (File)
Tue, Jun 14, 6:15 PM
Unknown Object (File)
Tue, Jun 14, 4:53 AM
Subscribers

Details

Summary

Ref T5568. Use the very-new, very-beta ArcanistConfigurationDrivenUnitTestEngine unit test engine.

Test Plan

arc unit

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Use the configuration driven unit test engine.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
.arcconfig
2–3

I'm fine with auto-selecting this in the presence of .arcunit as soon as you're ready for it.

.arcunit
6

Maybe only in src/?

This revision is now accepted and ready to land.Aug 10 2015, 9:12 PM
.arcunit
6

Besides the fact that there are currently only tests for code in src/, is there any other compelling reason to limit this to src/?

I don't think there's any particular reason to limit it.

And I suppose we might eventually ship other libraries in optional/ or something, which would make limiting it not so good.

Hmm, would the libraries have unit tests that we want to run though?

No idea. If there was, say, a template application that we shipped with as a starting point for third parties and it had some example tests in it, we probably would, which seems plausible, maybe?

This revision was automatically updated to reflect the committed changes.