Remove VotableInterface from PonderQuestion
ClosedPublic
Actions

Authored by chad on Aug 9 2015, 1:57 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T6920: Move Voting in Ponder to "Helpfuls"

Commits

Restricted Diffusion Commit
rP7e7e38e9c009: Remove VotableInterface from PonderQuestion

Summary

Ref T6920, This removes the PonderVotableInterface from PonderQuestion and assocaited code. Also... never used?

Test Plan

Visit Ponder, See List, New Question, Add Answer.

Diff Detail

Repository

rP Phabricator

Branch

ponder-question-vote

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7545
Build 8130: [Placeholder Plan] Wait for 30 Seconds
Build 8129: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33408.Aug 9 2015, 1:57 AM

chad retitled this revision from to Remove VotableInterface from PonderQuestion.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T6920: Move Voting in Ponder to "Helpfuls".

Herald added a subscriber: Korvin. · View Herald TranscriptAug 9 2015, 1:57 AM

Should I also write a script to clean out edge/edgedata?

Remove edge files

You can just write a .sql file which does this, I think:

/* Removes Ponder vote data. */

DELETE FROM {$NAMESPACE}_ponder.edge
  WHERE type IN (17, 18, 19, 20);

DELETE FROM {$NAMESPACE}_user.edge
  WHERE type IN (17, 18, 19, 20);

That should get rid of everything without requiring a messier/more complicated migration (that also gets rid of the answer votes).

However, it might be good to wait a month or so to do this, just in case someone really wants their vote data. Keeping the edges around for a bit won't hurt anything.

This revision is now accepted and ready to land.Aug 9 2015, 3:26 AM