Page MenuHomePhabricator

Make "Active" the default query for People
AbandonedPublic

Authored by cburroughs on Sep 25 2014, 9:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 15, 3:42 PM
Unknown Object (File)
Sun, Jul 7, 9:37 PM
Unknown Object (File)
Jun 10 2024, 7:57 AM
Unknown Object (File)
Jun 10 2024, 7:04 AM
Unknown Object (File)
May 19 2024, 9:58 PM
Unknown Object (File)
May 13 2024, 6:49 PM
Unknown Object (File)
May 13 2024, 5:09 PM
Unknown Object (File)
May 12 2024, 10:47 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

On corporate installs the number of former employees can easily rival current ones. The results in the "All" view for the People app showing a lot of noise. Create a new "Active" query showing non-disabled users, and make that the default.

Test Plan

On an install with disabled users:

  • Go to /people/ and see the nice highlight for "Active".
  • Look at the results and verify that none of them are disabled.
  • Click on "All" and verify disabled users are still there.
  • Explicitly click on "Active" and see that it's no different than default.

Diff Detail

Repository
rP Phabricator
Branch
active-people
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5926
Build 5946: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

cburroughs retitled this revision from to make 'Active' the default query for People.
cburroughs updated this object.
cburroughs edited the test plan for this revision. (Show Details)
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
joshuaspence retitled this revision from make 'Active' the default query for People to make "Active" the default query for People.Feb 25 2015, 9:43 AM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a subscriber: joshuaspence.
joshuaspence retitled this revision from make "Active" the default query for People to Make "Active" the default query for People.Feb 25 2015, 9:45 AM
epriestley added a reviewer: epriestley.

I rolled this into D13122.

This revision now requires changes to proceed.Jun 2 2015, 5:28 PM