Page MenuHomePhabricator
Differential D13000

Make "Tags" and "Branches" custom fields work properly in Diffusion
ClosedPublic
Actions

Authored by epriestley on May 25 2015, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:42 AM
Unknown Object (File)
Fri, Apr 19, 11:54 PM
Unknown Object (File)
Fri, Apr 19, 11:54 PM
Unknown Object (File)
Fri, Apr 19, 10:47 PM
Unknown Object (File)
Fri, Apr 19, 10:03 PM
Unknown Object (File)
Fri, Apr 19, 1:52 PM
Unknown Object (File)
Fri, Apr 19, 2:02 AM
Unknown Object (File)
Fri, Apr 12, 2:30 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
fabe
Maniphest Tasks
T8295: Show which commits were included in a merge commit in Herald emails
Commits
Restricted Diffusion Commit
rP3d2c6f1ed27d: Make "Tags" and "Branches" custom fields work properly in Diffusion
Summary

Ref T8295 (vaguely related). This old method has no callsites.

Test Plan

Generated mail, saw "Tags" and "Branches".

Diff Detail

Repository
rP Phabricator
Branch
buildmailbody
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6259
Build 6281: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31348.May 25 2015, 12:27 PM
epriestley retitled this revision from to Make "Tags" and "Branches" custom fields work properly in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, fabe.
epriestley added a task: T8295: Show which commits were included in a merge commit in Herald emails.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2015, 12:27 PM
fabe accepted this revision.May 25 2015, 12:30 PM
fabe edited edge metadata.
This revision is now accepted and ready to land.May 25 2015, 12:30 PM
joshuaspence accepted this revision.May 25 2015, 12:30 PM
joshuaspence edited edge metadata.
joshuaspence added a child revision: D12997: Add repository to audit emails.
Closed by commit rP3d2c6f1ed27d: Make "Tags" and "Branches" custom fields work properly in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyMay 25 2015, 12:34 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T8336: Make a workflow that integrates nicely with list based email/patch reviews.May 28 2015, 3:34 PM
epriestley mentioned this in T8566: Specify branch in commit email.Jun 16 2015, 8:06 PM
epriestley mentioned this in T8574: Users receiving many duplicate emails.Jun 16 2015, 10:49 PM

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
customfield/
9 lines
9 lines
infrastructure/
customfield/
field/
16 lines

Diff 31348

View Options

src/applications/repository/customfield/PhabricatorCommitBranchesField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitTagsField.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
Phabricator · Built by Phacility