Page MenuHomePhabricator
Differential D12997

Add repository to audit emails
ClosedPublic
Actions

Authored by joshuaspence on May 25 2015, 11:40 AM.
Tags
None
Referenced Files
F13089881: D12997.diff
Thu, Apr 25, 2:03 AM
F13084624: D12997.diff
Wed, Apr 24, 11:12 PM
Unknown Object (File)
Tue, Apr 23, 4:09 AM
Unknown Object (File)
Sun, Apr 21, 9:15 PM
Unknown Object (File)
Sun, Apr 21, 9:15 PM
Unknown Object (File)
Sun, Apr 21, 9:15 PM
Unknown Object (File)
Sun, Apr 21, 9:15 PM
Unknown Object (File)
Sun, Apr 21, 9:04 PM
View All Files
Subscribers
epriestley
fabe
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6897: Diffusion commit email notification does not specify branch
Commits
Restricted Diffusion Commit
rPbe19b31a6444: Add repository to audit emails
Summary

This is vaguely related to T5791. Add a "REPOSITORY" header to audit emails so that they can be filtered in Gmail.

Test Plan

Commented on an audit and used ./bin/mail show-outbound to inspect outbound email.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6255
Build 6277: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31338.May 25 2015, 11:40 AM
joshuaspence retitled this revision from to Add repository to audit emails.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 25 2015, 11:40 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley requested changes to this revision.May 25 2015, 11:41 AM
epriestley edited edge metadata.

I'll accept this as a default-disabled custom field after D12993, see T8295.

This revision now requires changes to proceed.May 25 2015, 11:41 AM
joshuaspence added a parent revision: D12993: show merged commits in herald emails for merge commits.May 25 2015, 11:43 AM

Seems reasonable.

epriestley added a comment.May 25 2015, 11:49 AM

Dependency is in HEAD now.

joshuaspence updated this revision to Diff 31343.May 25 2015, 12:02 PM
joshuaspence edited edge metadata.

Convert to custom field

joshuaspence added a comment.May 25 2015, 12:02 PM

This doesn't actually seem to work, presumably because D12993 was intended for Herald emails?

fabe added a subscriber: fabe.May 25 2015, 12:07 PM

I think you need to use updateTransactionMailBody instead of buildApplicationTransactionMailBody.

The later one has a comment on it saying:
TODO: this is only used by Diffusion right now and everything is completely
faked since Diffusion doesn't use ApplicationTransactions yet. This should
get fleshed out as we have more use cases.

and i can't actually find where it is called...

epriestley added a comment.May 25 2015, 12:18 PM

I'll fix the buildOldJunk callsites.

joshuaspence added a parent revision: D13000: Make "Tags" and "Branches" custom fields work properly in Diffusion.May 25 2015, 12:31 PM
joshuaspence updated this revision to Diff 31356.May 25 2015, 12:41 PM
joshuaspence edited edge metadata.

Rebase. Yep, it seems to work now!

epriestley accepted this revision.May 25 2015, 12:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 25 2015, 12:43 PM
Closed by commit rPbe19b31a6444: Add repository to audit emails (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 25 2015, 12:43 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a task: T6897: Diffusion commit email notification does not specify branch.May 26 2015, 9:59 PM
epriestley mentioned this in T8336: Make a workflow that integrates nicely with list based email/patch reviews.May 28 2015, 3:34 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
config/
10 lines
repository/
customfield/
29 lines

Diff 31343

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitRepositoryField.php

Loading...
Phabricator · Built by Phacility