Page MenuHomePhabricator

Add repository to audit emails
ClosedPublic

Authored by joshuaspence on May 25 2015, 11:40 AM.

Details

Summary

This is vaguely related to T5791. Add a "REPOSITORY" header to audit emails so that they can be filtered in Gmail.

Test Plan

Commented on an audit and used ./bin/mail show-outbound to inspect outbound email.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 6255
Build 6277: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Add repository to audit emails.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley requested changes to this revision.May 25 2015, 11:41 AM
epriestley edited edge metadata.

I'll accept this as a default-disabled custom field after D12993, see T8295.

This revision now requires changes to proceed.May 25 2015, 11:41 AM

Dependency is in HEAD now.

joshuaspence edited edge metadata.

Convert to custom field

This doesn't actually seem to work, presumably because D12993 was intended for Herald emails?

fabe added a subscriber: fabe.May 25 2015, 12:07 PM

I think you need to use updateTransactionMailBody instead of buildApplicationTransactionMailBody.

The later one has a comment on it saying:
TODO: this is only used by Diffusion right now and everything is completely
faked since Diffusion doesn't use ApplicationTransactions yet. This should
get fleshed out as we have more use cases.

and i can't actually find where it is called...

I'll fix the buildOldJunk callsites.

joshuaspence edited edge metadata.

Rebase. Yep, it seems to work now!

epriestley accepted this revision.May 25 2015, 12:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 25 2015, 12:43 PM
This revision was automatically updated to reflect the committed changes.