Differential D12929

Transactions - make customization of TYPE_EDGE optional
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 6:15 PM.

Tags

None

Referenced Files

	F19081477: D12929.id31121.diff
	Tue, Dec 2, 7:03 AM

	F18906787: D12929.id.diff
	Nov 8 2025, 8:27 PM

	F18900617: D12929.diff
	Nov 7 2025, 9:12 PM

	F18873341: D12929.id31121.diff
	Nov 5 2025, 9:14 AM

	F18853134: D12929.diff
	Oct 31 2025, 2:27 PM

	F18750469: D12929.id31122.diff
	Oct 4 2025, 7:53 AM

	F18748277: D12929.id.diff
	Oct 3 2025, 8:23 PM

	F18746690: D12929.diff
	Oct 3 2025, 1:11 PM

Subscribers

Tokens

"Haypence" token, awarded by epriestley.

Details

Reviewers

Maniphest Tasks

T6403: Make application customization of builtin transaction types optional

Commits

Restricted Diffusion Commit
rP16c8d44c37c9: Transactions - make customization of TYPE_EDGE optional

Summary

Ref T6403. This does TYPE_EDGE since I just had to deal with T8252. Look like this fixes a few editors (maybe) that would have had fatals with mentions like slowvote and ponder.

Test Plan

made a phame post mentioning a task and it worked! joined / left a project, watched / unwatched a project and that worked! blind faith for other sites.

Diff Detail

Repository

Branch

T6403

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6122
Build 6143: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31121.May 19 2015, 6:15 PM

btrahan added a task: T6403: Make application customization of builtin transaction types optional.

btrahan retitled this revision from to Transactions - make customization of TYPE_EDGE optional.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 6:15 PM

epriestley accepted this revision.May 19 2015, 6:20 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 6:20 PM

epriestley awarded a token.May 19 2015, 6:20 PM

Closed by commit rP16c8d44c37c9: Transactions - make customization of TYPE_EDGE optional (authored by btrahan, committed by btrahan). · Explain WhyMay 19 2015, 6:26 PM

This revision was automatically updated to reflect the committed changes.

btrahan mentioned this in D12940: Transactions - fix bug adding people to projects.May 19 2015, 10:21 PM

btrahan mentioned this in rP2154f17b3d7b: Transactions - fix bug adding people to projects.May 19 2015, 10:22 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

editor/

AlmanacDeviceEditor.php

2 lines

AlmanacServiceEditor.php

2 lines

audit/

editor/

PhabricatorAuditEditor.php

2 lines

calendar/

editor/

PhabricatorCalendarEventEditor.php

2 lines

dashboard/

editor/

PhabricatorDashboardPanelTransactionEditor.php

3 lines

PhabricatorDashboardTransactionEditor.php

4 lines

differential/

editor/

DifferentialTransactionEditor.php

3 lines

fund/

editor/

FundInitiativeEditor.php

2 lines

paste/

editor/

PhabricatorPasteEditor.php

2 lines

phame/

editor/

PhamePostEditor.php

3 lines

pholio/

editor/

PholioMockEditor.php

4 lines

phortune/

editor/

PhortuneAccountEditor.php

4 lines

PhortuneMerchantEditor.php

2 lines

ponder/

editor/

PonderQuestionEditor.php

2 lines

project/

editor/

PhabricatorProjectTransactionEditor.php

17 lines

slowvote/

editor/

PhabricatorSlowvoteEditor.php

2 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

3 lines

Diff 31121

src/applications/almanac/editor/AlmanacDeviceEditor.php

Loading...

src/applications/almanac/editor/AlmanacServiceEditor.php

Loading...

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...

src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php

Loading...

src/applications/dashboard/editor/PhabricatorDashboardTransactionEditor.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/fund/editor/FundInitiativeEditor.php

Loading...

src/applications/paste/editor/PhabricatorPasteEditor.php

Loading...

src/applications/phame/editor/PhamePostEditor.php

Loading...

src/applications/pholio/editor/PholioMockEditor.php

Loading...

src/applications/phortune/editor/PhortuneAccountEditor.php

Loading...

src/applications/phortune/editor/PhortuneMerchantEditor.php

Loading...

src/applications/ponder/editor/PonderQuestionEditor.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...