Page MenuHomePhabricator
Differential D12940

Transactions - fix bug adding people to projects
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 10:21 PM.
Tags
None
Referenced Files
F15532274: D12940.id31158.diff
Wed, Apr 23, 3:17 PM
F15529490: D12940.id31158.diff
Tue, Apr 22, 8:11 PM
F15528669: D12940.diff
Tue, Apr 22, 1:08 PM
F15506486: D12940.id31158.diff
Tue, Apr 15, 11:40 AM
F15489823: D12940.id31158.diff
Fri, Apr 11, 12:34 PM
F15463257: D12940.id.diff
Tue, Apr 1, 9:50 PM
F15431600: D12940.id.diff
Mar 24 2025, 1:23 PM
F15425332: D12940.id31159.diff
Mar 23 2025, 4:10 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Like" token, awarded by epriestley.

Details

Reviewers
epriestley
chad
Maniphest Tasks
T6403: Make application customization of builtin transaction types optional
T8264: Oddness adding people to the Dropbox project
Commits
Restricted Diffusion Commit
rP2154f17b3d7b: Transactions - fix bug adding people to projects
Summary

Fixes T8264. Broken in D12929. Sweep all the applyBuiltin implementations and always break; rather than return

Test Plan

added myself to a project successfully (showed up as a member)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 31158.May 19 2015, 10:21 PM
btrahan added a task: T8264: Oddness adding people to the Dropbox project.
btrahan retitled this revision from to Transactions - fix bug adding people to projects.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 10:21 PM
btrahan added a task: T6403: Make application customization of builtin transaction types optional.May 19 2015, 10:22 PM
Closed by commit rP2154f17b3d7b: Transactions - fix bug adding people to projects (authored by btrahan, committed by btrahan). · Explain WhyMay 19 2015, 10:22 PM
This revision was automatically updated to reflect the committed changes.
epriestley awarded a token.May 19 2015, 11:38 PM

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
2 lines
differential/
editor/
2 lines
project/
editor/
6 lines

Diff 31159

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
Phabricator · Built by Phacility