Page MenuHomePhabricator
Differential D12888

`pht`ize a bunch more strings
ClosedPublic
Actions

Authored by joshuaspence on May 17 2015, 9:46 PM.
Tags
None
Referenced Files
F15394772: D12888.id30991.diff
Sun, Mar 16, 1:04 AM
F15393482: D12888.id.diff
Sat, Mar 15, 9:02 PM
F15392928: D12888.diff
Sat, Mar 15, 6:34 PM
F15392640: D12888.id31266.diff
Sat, Mar 15, 4:33 PM
F15390245: D12888.diff
Sat, Mar 15, 6:03 AM
F15383392: D12888.diff
Fri, Mar 14, 4:30 PM
F15383097: D12888.id31266.diff
Fri, Mar 14, 3:33 PM
F15353292: D12888.id31266.diff
Mon, Mar 10, 8:52 PM
View All Files
Subscribers
aurelijus
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC6f8686610489: `pht`ize a bunch more strings
Summary

I found a few strings that I had missed, using a mostly-broken-but-somewhat-okay custom linter ruler (https://secure.phabricator.com/differential/diff/30988/).

Test Plan

Intense eyeballing.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30991.May 17 2015, 9:46 PM
joshuaspence retitled this revision from to `pht`ize a bunch more strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2015, 9:46 PM
Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript
epriestley accepted this revision.May 19 2015, 1:58 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 1:58 PM
Closed by commit rARC6f8686610489: `pht`ize a bunch more strings (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 22 2015, 7:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31266

View Options

scripts/__init_script__.php

Loading...
View Options

src/difference/__tests__/ArcanistDiffUtilsTestCase.php

Loading...
View Options

src/internationalization/ArcanistUSEnglishTranslation.php

Loading...
View Options

src/lint/linter/ArcanistClosureLinter.php

Loading...
View Options

src/lint/linter/ArcanistJSONLintLinter.php

Loading...
View Options

src/lint/linter/ArcanistJSONLinter.php

Loading...
View Options

src/lint/linter/ArcanistPhutilLibraryLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
View Options

src/lint/linter/xhpast/__tests__/ArcanistXHPASTLintNamingHookTestCase.php

Loading...
View Options

src/parser/ArcanistDiffParser.php

Loading...
View Options

src/parser/__tests__/ArcanistBaseCommitParserTestCase.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/unit/engine/PhutilUnitTestEngine.php

Loading...
View Options

src/unit/parser/ArcanistPhpunitTestResultParser.php

Loading...
View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

Loading...
View Options

src/workflow/ArcanistBackoutWorkflow.php

Loading...
View Options

src/workflow/ArcanistCommitWorkflow.php

Loading...
View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
View Options

src/workflow/ArcanistDownloadWorkflow.php

Loading...
View Options

src/workflow/ArcanistHelpWorkflow.php

Loading...
View Options

src/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistWhichWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility