Differential D12888

`pht`ize a bunch more strings
ClosedPublic
Actions

Authored by joshuaspence on May 17 2015, 9:46 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC6f8686610489: `pht`ize a bunch more strings

Summary

I found a few strings that I had missed, using a mostly-broken-but-somewhat-okay custom linter ruler (https://secure.phabricator.com/differential/diff/30988/).

Test Plan

Intense eyeballing.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6045
Build 6065: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30991.May 17 2015, 9:46 PM

joshuaspence retitled this revision from to `pht`ize a bunch more strings.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2015, 9:46 PM

Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript

epriestley accepted this revision.May 19 2015, 1:58 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 1:58 PM

Closed by commit rARC6f8686610489: `pht`ize a bunch more strings (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 22 2015, 7:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

__init_script__.php

4 lines

src/

difference/

__tests__/

ArcanistDiffUtilsTestCase.php

4 lines

internationalization/

ArcanistUSEnglishTranslation.php

17 lines

lint/

linter/

ArcanistClosureLinter.php

2 lines

ArcanistJSONLintLinter.php

2 lines

ArcanistJSONLinter.php

2 lines

ArcanistPhutilLibraryLinter.php

2 lines

ArcanistXHPASTLinter.php

9 lines

__tests__/

ArcanistLinterTestCase.php

2 lines

xhpast/

__tests__/

ArcanistXHPASTLintNamingHookTestCase.php

8 lines

parser/

ArcanistDiffParser.php

6 lines

__tests__/

ArcanistBaseCommitParserTestCase.php

24 lines

repository/

api/

ArcanistGitAPI.php

5 lines

unit/

engine/

PhutilUnitTestEngine.php

2 lines

parser/

ArcanistPhpunitTestResultParser.php

16 lines

renderer/

ArcanistUnitConsoleRenderer.php

8 lines

workflow/

ArcanistBackoutWorkflow.php

2 lines

ArcanistCommitWorkflow.php

2 lines

ArcanistDiffWorkflow.php

575 lines

ArcanistDownloadWorkflow.php

2 lines

ArcanistHelpWorkflow.php

2 lines

ArcanistShellCompleteWorkflow.php

2 lines

ArcanistWhichWorkflow.php

4 lines

ArcanistWorkflow.php

35 lines

Diff 30991

View Options

scripts/__init_script__.php

View Options

src/difference/tests/ArcanistDiffUtilsTestCase.php

View Options

src/internationalization/ArcanistUSEnglishTranslation.php

View Options

src/lint/linter/ArcanistClosureLinter.php

View Options

src/lint/linter/ArcanistJSONLintLinter.php

View Options

src/lint/linter/ArcanistJSONLinter.php

View Options

src/lint/linter/ArcanistPhutilLibraryLinter.php

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

View Options

src/lint/linter/xhpast/tests/ArcanistXHPASTLintNamingHookTestCase.php

View Options

src/parser/ArcanistDiffParser.php

View Options

src/parser/tests/ArcanistBaseCommitParserTestCase.php

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/unit/engine/PhutilUnitTestEngine.php

View Options

src/unit/parser/ArcanistPhpunitTestResultParser.php

View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

View Options

src/workflow/ArcanistBackoutWorkflow.php

View Options

src/workflow/ArcanistCommitWorkflow.php

View Options

src/workflow/ArcanistDiffWorkflow.php

View Options

src/workflow/ArcanistDownloadWorkflow.php

View Options

src/workflow/ArcanistHelpWorkflow.php

View Options

src/workflow/ArcanistShellCompleteWorkflow.php

View Options

src/workflow/ArcanistWhichWorkflow.php

View Options

src/workflow/ArcanistWorkflow.php

`pht`ize a bunch more stringsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30991

scripts/__init_script__.php

src/difference/__tests__/ArcanistDiffUtilsTestCase.php

src/internationalization/ArcanistUSEnglishTranslation.php

src/lint/linter/ArcanistClosureLinter.php

src/lint/linter/ArcanistJSONLintLinter.php

src/lint/linter/ArcanistJSONLinter.php

src/lint/linter/ArcanistPhutilLibraryLinter.php

src/lint/linter/ArcanistXHPASTLinter.php

src/lint/linter/__tests__/ArcanistLinterTestCase.php

src/lint/linter/xhpast/__tests__/ArcanistXHPASTLintNamingHookTestCase.php

src/parser/ArcanistDiffParser.php

src/parser/__tests__/ArcanistBaseCommitParserTestCase.php

src/repository/api/ArcanistGitAPI.php

src/unit/engine/PhutilUnitTestEngine.php

src/unit/parser/ArcanistPhpunitTestResultParser.php

src/unit/renderer/ArcanistUnitConsoleRenderer.php

src/workflow/ArcanistBackoutWorkflow.php

src/workflow/ArcanistCommitWorkflow.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistDownloadWorkflow.php

src/workflow/ArcanistHelpWorkflow.php

src/workflow/ArcanistShellCompleteWorkflow.php

src/workflow/ArcanistWhichWorkflow.php

src/workflow/ArcanistWorkflow.php

`pht`ize a bunch more strings
ClosedPublic
Actions

Revision Contents
Changeset List

src/difference/tests/ArcanistDiffUtilsTestCase.php

src/lint/linter/tests/ArcanistLinterTestCase.php

src/lint/linter/xhpast/tests/ArcanistXHPASTLintNamingHookTestCase.php

src/parser/tests/ArcanistBaseCommitParserTestCase.php