Paths

Table of Contentst

Differential D12783

Implement leasing working copies from Drydock
AbandonedPublic
Actions

Authored by hach-que on May 9 2015, 9:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 30, 3:37 PM

	Unknown Object (File)
	Thu, Jan 30, 2:52 PM

	Unknown Object (File)
	Tue, Jan 28, 11:31 PM

	Unknown Object (File)
	Sun, Jan 26, 9:10 PM

	Unknown Object (File)
	Sat, Jan 25, 5:52 PM

	Unknown Object (File)
	Fri, Jan 24, 6:24 AM

	Unknown Object (File)
	Wed, Jan 22, 7:18 AM

	Unknown Object (File)
	Tue, Jan 21, 11:17 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1049: Implement Harbormaster
T2015: Implement Drydock

Summary

Ref T1049. Ref T2015. This implements the "working copy" blueprint in Drydock and allows Harbormaster to lease from it. More importantly, this implements a cache for repositories, such that a cache of the remote repository is maintained per host resource, and subsequent working copy leases perform git fetch --all on the cache and clone locally.

Currently the working copy blueprint supports taking a lease based on buildablePHIDs, but could easily be extended to allow custom leases. It also resolves revision buildables to their diff / revision IDs, but does not yet support actually acquiring a lease based on a revision.

Test Plan

Tested it with something like:

bin/drydock --trace lease --type working-copy --attributes platform=windows,buildablePHID=PHID-HMBB-y4uubdbzgaobsmlvwwa3

and saw everything work.

Diff Detail

Repository

Branch

drydock-working-copy-20150509

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php:23	XHP16	TODO Comment
Advice	src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php:46	XHP16	TODO Comment

Unit

Test Failures

Build Status

Buildable 5877
Build 5897: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,474 ms	PhabricatorLibraryTestCase::testMethodVisibility
	2,007 ms	PhabricatorCelerityTestCase::testCelerityMaps
	17 ms	PhabricatorConduitTestCase::testConduitMethods
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled
	1 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
		View Full Test Results (1 Failed · 6 Passed)

Event Timeline

hach-que updated this revision to Diff 30728.May 9 2015, 9:22 AM

hach-que retitled this revision from to Implement leasing working copies from Drydock.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added tasks: T2015: Implement Drydock, T1049: Implement Harbormaster.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 9 2015, 9:22 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Move private field to the top of the class

Use the public clone URI so that self-hosted repositories work

20after4 added a subscriber: 20after4.May 9 2015, 8:23 PM

joshuaspence added a subscriber: joshuaspence.May 9 2015, 10:10 PM

Ensure working copies are only allocated once per host
Fixes for working copy implementation
Fix working copy cache update
Cache submodules in working copies

Support cache-only mode to reduce submodule lease time

Prevent working copy resources from being created for other platforms

Add an optional host-platform parameter for working copies

mikn added a subscriber: mikn.Jun 9 2015, 8:40 AM

hach-que added a child revision: D13413: Implement leasing working copies based on URLs and repositories.Jun 24 2015, 6:22 AM

hach-que added a child revision: D13420: Fix issues with working copies not leasing against correct resources.Jun 25 2015, 5:37 AM

Superseded by newer revisions.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

drydock/

blueprint/

DrydockBlueprintImplementation.php

27 lines

DrydockWorkingCopyBlueprintImplementation.php

399 lines

customfield/

DrydockBlueprintCustomFieldBlueprints.php

50 lines

phid/

DrydockBlueprintPHIDType.php

1 line

typeahead/

DrydockBlueprintDatasource.php

52 lines

worker/

DrydockAllocatorWorker.php

12 lines

harbormaster/

step/

HarbormasterLeaseWorkingCopyBuildStepImplementation.php

84 lines

Diff 30728

src/__phutil_library_map__.php

Loading...

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...

src/applications/drydock/customfield/DrydockBlueprintCustomFieldBlueprints.php

Loading...

src/applications/drydock/phid/DrydockBlueprintPHIDType.php

Loading...

src/applications/drydock/typeahead/DrydockBlueprintDatasource.php

Loading...

src/applications/drydock/worker/DrydockAllocatorWorker.php

Loading...

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php

Loading...