Page MenuHomePhabricator
Differential D12667

Replace ArcanistPhutilTestCase refs with PhutilTestCase
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 7:37 AM.
Tags
None
Referenced Files
F14027807: D12667.id31165.diff
Fri, Nov 8, 9:43 AM
F14013067: D12667.id30429.diff
Sat, Nov 2, 12:23 AM
F14013066: D12667.id30629.diff
Sat, Nov 2, 12:23 AM
F13999712: D12667.diff
Thu, Oct 24, 4:42 PM
F13998942: D12667.diff
Thu, Oct 24, 11:56 AM
F13995016: D12667.id30429.diff
Wed, Oct 23, 10:06 AM
F13994888: D12667.id.diff
Wed, Oct 23, 9:07 AM
F13994884: D12667.id31165.diff
Wed, Oct 23, 9:04 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
avivey
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7977: Associate Symbols with Repositories directly (Instead of arc projects)
Commits
Restricted Diffusion Commit
rP69940f2b9ee4: Replace ArcanistPhutilTestCase refs with PhutilTestCase
Summary

Ref T7977. Remove the PhabricatorTestCase::getLink method. Depends on D12665.

Test Plan

arc unit.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5691
Build 5710: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30429.May 3 2015, 7:37 AM
joshuaspence retitled this revision from to Remove getLink method.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7977: Associate Symbols with Repositories directly (Instead of arc projects).
joshuaspence added a parent revision: D12664: Improve getLink method for unit tests.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 7:37 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 30629.May 7 2015, 11:07 AM
joshuaspence edited edge metadata.

Rebase

joshuaspence updated this object.May 7 2015, 11:07 AM
joshuaspence edited the test plan for this revision. (Show Details)
avivey updated this object.May 19 2015, 2:06 AM
avivey added a parent revision: D12665: Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase.
avivey retitled this revision from Remove getLink method to Replace `ArcanistPhutilTestCase` refs with `PhutilTestCase`.
avivey accepted this revision.May 19 2015, 2:15 AM
avivey added a reviewer: avivey.
joshuaspence removed a parent revision: D12664: Improve getLink method for unit tests.May 19 2015, 1:19 PM
joshuaspence retitled this revision from Replace `ArcanistPhutilTestCase` refs with `PhutilTestCase` to Replace ArcanistPhutilTestCase refs with PhutilTestCase.
joshuaspence edited edge metadata.
epriestley accepted this revision.May 19 2015, 2:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 2:12 PM
Closed by commit rP69940f2b9ee4: Replace ArcanistPhutilTestCase refs with PhutilTestCase (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
10 lines
applications/
differential/
storage/
__tests__/
2 lines
2 lines
diffusion/
request/
__tests__/
2 lines
docs/
contributor/
4 lines
user/
userguide/
2 lines
infrastructure/
testing/
10 lines

Diff 30429

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php

Loading...
View Options

src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php

Loading...
View Options

src/applications/diffusion/request/__tests__/DiffusionURITestCase.php

Loading...
View Options

src/docs/contributor/unit_tests.diviner

Loading...
View Options

src/docs/user/userguide/arcanist_coverage.diviner

Loading...
View Options

src/infrastructure/testing/PhabricatorTestCase.php

Loading...
Phabricator · Built by Phacility