Page MenuHomePhabricator
Differential D12666

Remove PhutilTestCase class
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 7:32 AM.
Tags
None
Referenced Files
F14054783: D12666.diff
Sat, Nov 16, 4:48 AM
F14011495: D12666.diff
Fri, Nov 1, 2:21 AM
F13989172: D12666.diff
Mon, Oct 21, 6:35 PM
Unknown Object (File)
Oct 6 2024, 8:57 AM
Unknown Object (File)
Sep 30 2024, 6:10 PM
Unknown Object (File)
Sep 27 2024, 7:27 AM
Unknown Object (File)
Sep 23 2024, 7:36 AM
Unknown Object (File)
Sep 17 2024, 8:10 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
avivey
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7977: Associate Symbols with Repositories directly (Instead of arc projects)
Commits
rPHUaa016bffbb60: Remove PhutilTestCase class
Summary

Ref T7977. Remove the PhutilTestCase class from rPHU and use the PhutilTestCase class from rARC instead. Depends on D12664.

Test Plan

arc unit

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5689
Build 5708: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30427.May 3 2015, 7:32 AM
joshuaspence retitled this revision from to Remove PhutilTestCase class.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7977: Associate Symbols with Repositories directly (Instead of arc projects).
joshuaspence added a parent revision: D12664: Improve getLink method for unit tests.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 7:32 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence added a child revision: D12665: Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase.May 7 2015, 11:04 AM
avivey accepted this revision.May 19 2015, 2:15 AM
avivey added a reviewer: avivey.
joshuaspence added a comment.May 19 2015, 1:16 PM
NOTE: This should be landed together with D12665
epriestley accepted this revision.May 19 2015, 2:12 PM
epriestley edited edge metadata.

This phutil -> arc -> phutil dependency is kind of garbage and it would be nice to straighten it out eventually, perhaps, although that seems conceptually hard.

This revision is now accepted and ready to land.May 19 2015, 2:12 PM
Closed by commit rPHUaa016bffbb60: Remove PhutilTestCase class (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
filesystem/
__tests__/
22 lines
infrastructure/
testing/
lexer/
__tests__/
2 lines
utils/
__tests__/
1 line

Diff 30427

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/filesystem/__tests__/FileFinderTestCase.php

Loading...
View Options

src/infrastructure/testing/PhutilTestCase.php

Loading...
View Options

src/lexer/__tests__/PhutilSimpleOptionsLexerTestCase.php

Loading...
View Options

src/utils/__tests__/PhutilLunarPhaseTestCase.php

Loading...
Phabricator · Built by Phacility