Paths

Table of Contentst

Differential D12664

Improve getLink method for unit tests
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 7:00 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 26, 4:56 PM

	Unknown Object (File)
	Mon, Nov 25, 10:11 PM

	Unknown Object (File)
	Mon, Nov 25, 7:26 PM

	Unknown Object (File)
	Thu, Nov 21, 1:43 PM

	Unknown Object (File)
	Wed, Nov 13, 2:21 AM

	Unknown Object (File)
	Sun, Nov 10, 8:32 PM

	Unknown Object (File)
	Sat, Nov 9, 4:25 AM

	Unknown Object (File)
	Fri, Nov 1, 2:21 AM

Subscribers

Details

Reviewers

epriestley
avivey

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7977: Associate Symbols with Repositories directly (Instead of arc projects)

Commits

rARC399f0400185f: Improve getLink method for unit tests

Summary

Ref T7977. The PhutilTestCase::getLink method currently relies on arcanist projects instead of repositories. Instead, make this logic a bit smarter by looking up the base URI from phabricator.uri (currently it is hardcoded to https://secure.phabricator.com).

Ideally, we would pass ?repositories=$REPOSITORY_PHID to DiffusionSymbolController as well, but I don't know if this is worth pursuing.

Test Plan

This diff.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/unit/engine/phutil/ArcanistPhutilTestCase.php:620	XHP16	TODO Comment

Unit

No Test Coverage

Build Status

Buildable 5687
Build 5706: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30424.May 3 2015, 7:00 AM

joshuaspence retitled this revision from to Improve getLink method for unit tests.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, avivey.

joshuaspence added a task: T7977: Associate Symbols with Repositories directly (Instead of arc projects).

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 7:00 AM

Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript

Simplify diff, will move other stuff to a separate diff

joshuaspence added a child revision: D12665: Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase.May 3 2015, 7:22 AM

joshuaspence added a child revision: D12666: Remove PhutilTestCase class.May 3 2015, 7:32 AM

joshuaspence added a child revision: D12667: Replace ArcanistPhutilTestCase refs with PhutilTestCase.May 3 2015, 7:37 AM

Seems to work now

joshuaspence updated this object.May 7 2015, 10:59 AM

joshuaspence edited the test plan for this revision. (Show Details)

Ok, it took me a while to understand what getLink is actually for in this code (It links to the source of the test).

The whole set looks ok to me, and is mostly technical, so .

avivey accepted this revision.May 19 2015, 2:15 AM

avivey edited edge metadata.

Use PhutilInvalidStateException

joshuaspence removed a child revision: D12667: Replace ArcanistPhutilTestCase refs with PhutilTestCase.May 19 2015, 1:19 PM

epriestley accepted this revision.May 19 2015, 2:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 2:10 PM

Closed by commit rARC399f0400185f: Improve getLink method for unit tests (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

testing/

ArcanistTestCase.php

12 lines

unit/

engine/

PhutilUnitTestEngine.php

9 lines

XUnitTestEngine.php

1 line

phutil/

ArcanistPhutilTestCase.php

38 lines

Diff 30425

src/infrastructure/testing/ArcanistTestCase.php

Loading...

src/unit/engine/PhutilUnitTestEngine.php

Loading...

src/unit/engine/XUnitTestEngine.php

Loading...

src/unit/engine/phutil/ArcanistPhutilTestCase.php

Loading...