Paths

Table of Contentst

Differential D12607

`pht` all the things
ClosedPublic
Actions

Authored by joshuaspence on Apr 29 2015, 1:00 PM.

Tags

None

Referenced Files

	F13151771: D12607.diff
	Sat, May 4, 6:48 PM

	Unknown Object (File)
	Wed, May 1, 12:11 AM

	Unknown Object (File)
	Thu, Apr 25, 4:31 PM

	Unknown Object (File)
	Thu, Apr 11, 8:53 AM

	Unknown Object (File)
	Fri, Apr 5, 8:06 PM

	Unknown Object (File)
	Apr 4 2024, 6:49 PM

	Unknown Object (File)
	Mar 30 2024, 10:17 AM

	Unknown Object (File)
	Mar 23 2024, 10:26 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCd2b38cdf9444: `pht` all the things

Summary

phtize almost all strings in rARC.

Test Plan

¯\_(ツ)_/¯

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5585
Build 5604: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	986 ms	ArcanistPuppetLintLinterTestCase::testLinter
	346 ms	ArcanistXMLLinterTestCase::testLinter
	101 ms	ArcanistBaseCommitParserTestCase::testBasics
	89 ms	ArcanistBaseCommitParserTestCase::testHalt
	96 ms	ArcanistBaseCommitParserTestCase::testJump
		View Full Test Results (2 Failed · 90 Passed · 5 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 30271.Apr 29 2015, 1:00 PM

joshuaspence retitled this revision from to `pht` all the things.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 29 2015, 1:00 PM

Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript

We do a little work before loading pht(), which is the only thing I'd be worried about, but this doesn't touch any of that as far as I can see.

This revision is now accepted and ready to land.Apr 29 2015, 1:18 PM

Rebase

Closed by commit rARCd2b38cdf9444: `pht` all the things (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 11:02 AM

This revision was automatically updated to reflect the committed changes.

nevogd mentioned this in D12837: Fix missing comma in sprintf() in ArcanistWorkflow..May 14 2015, 12:59 PM

epriestley mentioned this in rARC383633e63fd7: Fix missing comma in sprintf() in ArcanistWorkflow..May 14 2015, 12:59 PM

Large Diff

This large diff affects 114 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

src/

configuration/

ArcanistConfiguration.php

15 lines

ArcanistConfigurationManager.php

20 lines

ArcanistSettings.php

2 lines

__tests__/

ArcanistBritishTestCase.php

4 lines

difference/

ArcanistDiffUtils.php

2 lines

differential/

ArcanistDifferentialCommitMessage.php

8 lines

constants/

ArcanistDifferentialRevisionStatus.php

2 lines

exception/

usage/

ArcanistUserAbortException.php

2 lines

hgdaemon/

ArcanistHgClientChannel.php

2 lines

ArcanistHgProxyClient.php

5 lines

ArcanistHgProxyServer.php

35 lines

ArcanistHgServerChannel.php

3 lines

lint/

ArcanistLintPatcher.php

8 lines

ArcanistLintSeverity.php

12 lines

engine/

ArcanistLintEngine.php

8 lines

linter/

ArcanistBaseXHPASTLinter.php

5 lines

ArcanistCSharpLinter.php

40 lines

ArcanistCppcheckLinter.php

8 lines

ArcanistCpplintLinter.php

6 lines

ArcanistFlake8Linter.php

7 lines

ArcanistGeneratedLinter.php

4 lines

ArcanistGoLintLinter.php

4 lines

ArcanistHLintLinter.php

13 lines

ArcanistJSHintLinter.php

13 lines

ArcanistJSONLintLinter.php

4 lines

ArcanistJscsLinter.php

8 lines

ArcanistLesscLinter.php

17 lines

ArcanistLinter.php

17 lines

ArcanistPEP8Linter.php

2 lines

ArcanistPhpLinter.php

2 lines

ArcanistPhpcsLinter.php

7 lines

ArcanistPhutilXHPASTLinter.php

7 lines

ArcanistPyFlakesLinter.php

2 lines

ArcanistPyLintLinter.php

22 lines

ArcanistRuboCopLinter.php

6 lines

ArcanistRubyLinter.php

6 lines

ArcanistScriptAndRegexLinter.php

33 lines

ArcanistXMLLinter.php

2 lines

__tests__/

ArcanistCommitLinterTestCase.php

2 lines

ArcanistCppcheckLinterTestCase.php

2 lines

ArcanistCpplintLinterTestCase.php

2 lines

ArcanistLinterTestCase.php

5 lines

ArcanistNoLintLinterTestCase.php

2 lines

ArcanistPhutilXHPASTLinterTestCase.php

2 lines

ArcanistPyLintLinterTestCase.php

2 lines

renderer/

ArcanistConsoleLintRenderer.php

14 lines

ArcanistSummaryLintRenderer.php

4 lines

parser/

ArcanistBaseCommitParser.php

45 lines

ArcanistBundle.php

21 lines

ArcanistDiffParser.php

87 lines

__tests__/

ArcanistBundleTestCase.php

25 lines

ArcanistDiffParserTestCase.php

8 lines

diff/

ArcanistDiffChange.php

4 lines

ArcanistDiffChangeType.php

31 lines

ArcanistDiffHunk.php

2 lines

repository/

api/

ArcanistGitAPI.php

204 lines

ArcanistMercurialAPI.php

131 lines

ArcanistRepositoryAPI.php

3 lines

ArcanistSubversionAPI.php

26 lines

__tests__/

ArcanistRepositoryAPIStateTestCase.php

8 lines

parser/

ArcanistMercurialParser.php

21 lines

__tests__/

ArcanistMercurialParserTestCase.php

3 lines

unit/

engine/

ArcanistUnitTestEngine.php

8 lines

CSharpToolsTestEngine.php

11 lines

NoseTestEngine.php

12 lines

PhpunitTestEngine.php

8 lines

PhutilUnitTestEngine.php

29 lines

PytestTestEngine.php

2 lines

XUnitTestEngine.php

26 lines

__tests__/

PhutilUnitTestEngineTestCase.php

30 lines

phutil/

ArcanistPhutilTestCase.php

46 lines

parser/

ArcanistGoTestResultParser.php

1 line

ArcanistPhpunitTestResultParser.php

15 lines

ArcanistXUnitTestResultParser.php

9 lines

__tests__/

XUnitTestResultParserTestCase.php

4 lines

renderer/

ArcanistUnitConsoleRenderer.php

36 lines

workflow/

ArcanistAliasWorkflow.php

33 lines

ArcanistAmendWorkflow.php

65 lines

ArcanistBackoutWorkflow.php

15 lines

ArcanistBrowseWorkflow.php

24 lines

ArcanistCloseRevisionWorkflow.php

33 lines

ArcanistCloseWorkflow.php

36 lines

ArcanistCommitWorkflow.php

77 lines

ArcanistCoverWorkflow.php

9 lines

ArcanistDiffWorkflow.php

19 lines

ArcanistDownloadWorkflow.php

26 lines

ArcanistExportWorkflow.php

55 lines

ArcanistFeatureWorkflow.php

15 lines

ArcanistFlagWorkflow.php

27 lines

ArcanistGetConfigWorkflow.php

4 lines

ArcanistGitHookPreReceiveWorkflow.php

8 lines

ArcanistHelpWorkflow.php

19 lines

ArcanistInstallCertificateWorkflow.php

38 lines

ArcanistLandWorkflow.php

247 lines

ArcanistLiberateWorkflow.php

74 lines

ArcanistLintWorkflow.php

109 lines

ArcanistLintersWorkflow.php

6 lines

ArcanistListWorkflow.php

9 lines

ArcanistPasteWorkflow.php

2 lines

ArcanistPatchWorkflow.php

274 lines

ArcanistRevertWorkflow.php

4 lines

ArcanistSetConfigWorkflow.php

26 lines

ArcanistShellCompleteWorkflow.php

5 lines

ArcanistSvnHookPreCommitWorkflow.php

43 lines

ArcanistTasksWorkflow.php

27 lines

ArcanistTodoWorkflow.php

14 lines

ArcanistUnitWorkflow.php

57 lines

ArcanistUpgradeWorkflow.php

4 lines

ArcanistUploadWorkflow.php

4 lines

ArcanistVersionWorkflow.php

4 lines

ArcanistWhichWorkflow.php

70 lines

ArcanistWorkflow.php

129 lines

exception/

ArcanistCapabilityNotSupportedException.php

5 lines

workingcopyidentity/

ArcanistWorkingCopyIdentity.php

16 lines

Diff 30271

src/configuration/ArcanistConfiguration.php

src/configuration/ArcanistConfigurationManager.php

src/configuration/ArcanistSettings.php

src/configuration/tests/ArcanistBritishTestCase.php

src/difference/ArcanistDiffUtils.php

src/differential/ArcanistDifferentialCommitMessage.php

src/differential/constants/ArcanistDifferentialRevisionStatus.php

src/exception/usage/ArcanistUserAbortException.php

src/hgdaemon/ArcanistHgClientChannel.php

src/hgdaemon/ArcanistHgProxyClient.php

src/hgdaemon/ArcanistHgProxyServer.php

src/hgdaemon/ArcanistHgServerChannel.php

src/lint/ArcanistLintPatcher.php

src/lint/ArcanistLintSeverity.php

src/lint/engine/ArcanistLintEngine.php

src/lint/linter/ArcanistBaseXHPASTLinter.php

src/lint/linter/ArcanistCSharpLinter.php

src/lint/linter/ArcanistCppcheckLinter.php

src/lint/linter/ArcanistCpplintLinter.php

src/lint/linter/ArcanistFlake8Linter.php

src/lint/linter/ArcanistGeneratedLinter.php

src/lint/linter/ArcanistGoLintLinter.php

src/lint/linter/ArcanistHLintLinter.php

src/lint/linter/ArcanistJSHintLinter.php

src/lint/linter/ArcanistJSONLintLinter.php

src/lint/linter/ArcanistJscsLinter.php

src/lint/linter/ArcanistLesscLinter.php

src/lint/linter/ArcanistLinter.php

src/lint/linter/ArcanistPEP8Linter.php

src/lint/linter/ArcanistPhpLinter.php

src/lint/linter/ArcanistPhpcsLinter.php

src/lint/linter/ArcanistPhutilXHPASTLinter.php

src/lint/linter/ArcanistPyFlakesLinter.php

src/lint/linter/ArcanistPyLintLinter.php

src/lint/linter/ArcanistRuboCopLinter.php

src/lint/linter/ArcanistRubyLinter.php

src/lint/linter/ArcanistScriptAndRegexLinter.php

src/lint/linter/ArcanistXMLLinter.php

src/lint/linter/tests/ArcanistCommitLinterTestCase.php

src/lint/linter/tests/ArcanistCppcheckLinterTestCase.php

src/lint/linter/tests/ArcanistCpplintLinterTestCase.php

src/lint/linter/tests/ArcanistLinterTestCase.php

src/lint/linter/tests/ArcanistNoLintLinterTestCase.php

src/lint/linter/tests/ArcanistPhutilXHPASTLinterTestCase.php

src/lint/linter/tests/ArcanistPyLintLinterTestCase.php

src/lint/renderer/ArcanistConsoleLintRenderer.php

src/lint/renderer/ArcanistSummaryLintRenderer.php

src/parser/ArcanistBaseCommitParser.php

src/parser/ArcanistBundle.php

src/parser/ArcanistDiffParser.php

src/parser/tests/ArcanistBundleTestCase.php

src/parser/tests/ArcanistDiffParserTestCase.php

src/parser/diff/ArcanistDiffChange.php

src/parser/diff/ArcanistDiffChangeType.php

src/parser/diff/ArcanistDiffHunk.php

src/repository/api/ArcanistGitAPI.php

src/repository/api/ArcanistMercurialAPI.php

src/repository/api/ArcanistRepositoryAPI.php

src/repository/api/ArcanistSubversionAPI.php

src/repository/api/tests/ArcanistRepositoryAPIStateTestCase.php

src/repository/parser/ArcanistMercurialParser.php

src/repository/parser/tests/ArcanistMercurialParserTestCase.php

src/unit/engine/ArcanistUnitTestEngine.php

src/unit/engine/CSharpToolsTestEngine.php

src/unit/engine/NoseTestEngine.php

src/unit/engine/PhpunitTestEngine.php

src/unit/engine/PhutilUnitTestEngine.php

src/unit/engine/PytestTestEngine.php

src/unit/engine/XUnitTestEngine.php

src/unit/engine/tests/PhutilUnitTestEngineTestCase.php

src/unit/engine/phutil/ArcanistPhutilTestCase.php

src/unit/parser/ArcanistGoTestResultParser.php

src/unit/parser/ArcanistPhpunitTestResultParser.php

src/unit/parser/ArcanistXUnitTestResultParser.php

src/unit/parser/tests/XUnitTestResultParserTestCase.php

src/unit/renderer/ArcanistUnitConsoleRenderer.php

src/workflow/ArcanistAliasWorkflow.php

src/workflow/ArcanistAmendWorkflow.php

src/workflow/ArcanistBackoutWorkflow.php

src/workflow/ArcanistBrowseWorkflow.php

src/workflow/ArcanistCloseRevisionWorkflow.php

src/workflow/ArcanistCloseWorkflow.php

src/workflow/ArcanistCommitWorkflow.php

src/workflow/ArcanistCoverWorkflow.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistDownloadWorkflow.php

src/workflow/ArcanistExportWorkflow.php

src/workflow/ArcanistFeatureWorkflow.php

src/workflow/ArcanistFlagWorkflow.php

src/workflow/ArcanistGetConfigWorkflow.php

src/workflow/ArcanistGitHookPreReceiveWorkflow.php

src/workflow/ArcanistHelpWorkflow.php

src/workflow/ArcanistInstallCertificateWorkflow.php

src/workflow/ArcanistLandWorkflow.php

src/workflow/ArcanistLiberateWorkflow.php

src/workflow/ArcanistLintWorkflow.php

src/workflow/ArcanistLintersWorkflow.php

src/workflow/ArcanistListWorkflow.php

src/workflow/ArcanistPasteWorkflow.php

src/workflow/ArcanistPatchWorkflow.php

src/workflow/ArcanistRevertWorkflow.php

src/workflow/ArcanistSetConfigWorkflow.php

src/workflow/ArcanistShellCompleteWorkflow.php

src/workflow/ArcanistSvnHookPreCommitWorkflow.php

src/workflow/ArcanistTasksWorkflow.php

src/workflow/ArcanistTodoWorkflow.php

src/workflow/ArcanistUnitWorkflow.php

src/workflow/ArcanistUpgradeWorkflow.php

src/workflow/ArcanistUploadWorkflow.php

src/workflow/ArcanistVersionWorkflow.php

src/workflow/ArcanistWhichWorkflow.php

src/workflow/ArcanistWorkflow.php

src/workflow/exception/ArcanistCapabilityNotSupportedException.php

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php