Page MenuHomePhabricator
Differential D12607

`pht` all the things
ClosedPublic
Actions

Authored by joshuaspence on Apr 29 2015, 1:00 PM.
Tags
None
Referenced Files
F14754369: D12607.id30816.diff
Tue, Jan 21, 3:30 PM
Unknown Object (File)
Tue, Jan 21, 12:04 PM
Unknown Object (File)
Tue, Jan 21, 9:40 AM
Unknown Object (File)
Sun, Jan 19, 2:35 PM
Unknown Object (File)
Sat, Jan 18, 2:52 AM
Unknown Object (File)
Fri, Jan 17, 9:03 AM
Unknown Object (File)
Sat, Jan 11, 12:38 AM
Unknown Object (File)
Sat, Jan 11, 12:38 AM
View All Files
Subscribers
aurelijus
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCd2b38cdf9444: `pht` all the things
Summary

phtize almost all strings in rARC.

Test Plan

¯\_(ツ)_/¯

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30271.Apr 29 2015, 1:00 PM
joshuaspence retitled this revision from to `pht` all the things.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 29 2015, 1:00 PM
Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript
epriestley accepted this revision.Apr 29 2015, 1:18 PM
epriestley edited edge metadata.

We do a little work before loading pht(), which is the only thing I'd be worried about, but this doesn't touch any of that as far as I can see.

This revision is now accepted and ready to land.Apr 29 2015, 1:18 PM
joshuaspence updated this revision to Diff 30545.May 5 2015, 11:50 AM
joshuaspence edited edge metadata.

Rebase

Closed by commit rARCd2b38cdf9444: `pht` all the things (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 11:02 AM
This revision was automatically updated to reflect the committed changes.
nevogd mentioned this in D12837: Fix missing comma in sprintf() in ArcanistWorkflow..May 14 2015, 12:59 PM
epriestley mentioned this in rARC383633e63fd7: Fix missing comma in sprintf() in ArcanistWorkflow..May 14 2015, 12:59 PM

Large Diff

This large diff affects 110 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
configuration/
15 lines
20 lines
2 lines
__tests__/
4 lines
difference/
2 lines
differential/
constants/
2 lines
exception/
usage/
2 lines
hgdaemon/
2 lines
5 lines
35 lines
3 lines
lint/
8 lines
12 lines
engine/
8 lines
linter/
5 lines
40 lines
8 lines
6 lines
7 lines
4 lines
4 lines
13 lines
6 lines
4 lines
8 lines
17 lines
17 lines
2 lines
2 lines
7 lines
7 lines
2 lines
22 lines
6 lines
6 lines
2 lines
2 lines
__tests__/
2 lines
2 lines
5 lines
2 lines
2 lines
2 lines
renderer/
14 lines
4 lines
parser/
45 lines
21 lines
87 lines
__tests__/
25 lines
8 lines
diff/
4 lines
31 lines
2 lines
repository/
api/
204 lines
131 lines
3 lines
26 lines
__tests__/
8 lines
parser/
21 lines
__tests__/
3 lines
unit/
engine/
8 lines
11 lines
12 lines
8 lines
29 lines
2 lines
26 lines
__tests__/
30 lines
phutil/
46 lines
parser/
1 line
13 lines
10 lines
__tests__/
4 lines
renderer/
36 lines
workflow/
33 lines
65 lines
15 lines
22 lines
39 lines
37 lines
77 lines
9 lines
19 lines
26 lines
55 lines
15 lines
27 lines
4 lines
19 lines
40 lines
247 lines
74 lines
109 lines
6 lines
9 lines
2 lines
279 lines
4 lines
26 lines
4 lines
27 lines
14 lines
57 lines
4 lines
10 lines
4 lines
69 lines
262 lines
exception/
5 lines
workingcopyidentity/
16 lines

Diff 30816

View Options

src/configuration/ArcanistConfiguration.php

View Options

src/configuration/ArcanistConfigurationManager.php

View Options

src/configuration/ArcanistSettings.php

View Options

src/configuration/__tests__/ArcanistBritishTestCase.php

View Options

src/difference/ArcanistDiffUtils.php

View Options

src/differential/constants/ArcanistDifferentialRevisionStatus.php

View Options

src/exception/usage/ArcanistUserAbortException.php

View Options

src/hgdaemon/ArcanistHgClientChannel.php

View Options

src/hgdaemon/ArcanistHgProxyClient.php

View Options

src/hgdaemon/ArcanistHgProxyServer.php

View Options

src/hgdaemon/ArcanistHgServerChannel.php

View Options

src/lint/ArcanistLintPatcher.php

View Options

src/lint/ArcanistLintSeverity.php

View Options

src/lint/engine/ArcanistLintEngine.php

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php

View Options

src/lint/linter/ArcanistCSharpLinter.php

View Options

src/lint/linter/ArcanistCppcheckLinter.php

View Options

src/lint/linter/ArcanistCpplintLinter.php

View Options

src/lint/linter/ArcanistFlake8Linter.php

View Options

src/lint/linter/ArcanistGeneratedLinter.php

View Options

src/lint/linter/ArcanistGoLintLinter.php

View Options

src/lint/linter/ArcanistHLintLinter.php

View Options

src/lint/linter/ArcanistJSHintLinter.php

View Options

src/lint/linter/ArcanistJSONLintLinter.php

View Options

src/lint/linter/ArcanistJscsLinter.php

View Options

src/lint/linter/ArcanistLesscLinter.php

View Options

src/lint/linter/ArcanistLinter.php

View Options

src/lint/linter/ArcanistPEP8Linter.php

View Options

src/lint/linter/ArcanistPhpLinter.php

View Options

src/lint/linter/ArcanistPhpcsLinter.php

View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

View Options

src/lint/linter/ArcanistPyFlakesLinter.php

View Options

src/lint/linter/ArcanistPyLintLinter.php

View Options

src/lint/linter/ArcanistRuboCopLinter.php

View Options

src/lint/linter/ArcanistRubyLinter.php

View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

View Options

src/lint/linter/ArcanistXMLLinter.php

View Options

src/lint/linter/__tests__/ArcanistCppcheckLinterTestCase.php

View Options

src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php

View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

View Options

src/lint/linter/__tests__/ArcanistNoLintLinterTestCase.php

View Options

src/lint/linter/__tests__/ArcanistPhutilXHPASTLinterTestCase.php

View Options

src/lint/linter/__tests__/ArcanistPyLintLinterTestCase.php

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

View Options

src/lint/renderer/ArcanistSummaryLintRenderer.php

View Options

src/parser/ArcanistBaseCommitParser.php

View Options

src/parser/ArcanistBundle.php

View Options

src/parser/ArcanistDiffParser.php

View Options

src/parser/__tests__/ArcanistBundleTestCase.php

View Options

src/parser/__tests__/ArcanistDiffParserTestCase.php

View Options

src/parser/diff/ArcanistDiffChange.php

View Options

src/parser/diff/ArcanistDiffChangeType.php

View Options

src/parser/diff/ArcanistDiffHunk.php

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/api/ArcanistMercurialAPI.php

View Options

src/repository/api/ArcanistRepositoryAPI.php

View Options

src/repository/api/ArcanistSubversionAPI.php

View Options

src/repository/api/__tests__/ArcanistRepositoryAPIStateTestCase.php

View Options

src/repository/parser/ArcanistMercurialParser.php

View Options

src/repository/parser/__tests__/ArcanistMercurialParserTestCase.php

View Options

src/unit/engine/ArcanistUnitTestEngine.php

View Options

src/unit/engine/CSharpToolsTestEngine.php

View Options

src/unit/engine/NoseTestEngine.php

View Options

src/unit/engine/PhpunitTestEngine.php

View Options

src/unit/engine/PhutilUnitTestEngine.php

View Options

src/unit/engine/PytestTestEngine.php

View Options

src/unit/engine/XUnitTestEngine.php

View Options

src/unit/engine/__tests__/PhutilUnitTestEngineTestCase.php

View Options

src/unit/engine/phutil/ArcanistPhutilTestCase.php

View Options

src/unit/parser/ArcanistGoTestResultParser.php

View Options

src/unit/parser/ArcanistPhpunitTestResultParser.php

View Options

src/unit/parser/ArcanistXUnitTestResultParser.php

View Options

src/unit/parser/__tests__/XUnitTestResultParserTestCase.php

View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

View Options

src/workflow/ArcanistAliasWorkflow.php

View Options

src/workflow/ArcanistAmendWorkflow.php

View Options

src/workflow/ArcanistBackoutWorkflow.php

View Options

src/workflow/ArcanistBrowseWorkflow.php

View Options

src/workflow/ArcanistCloseRevisionWorkflow.php

View Options

src/workflow/ArcanistCloseWorkflow.php

View Options

src/workflow/ArcanistCommitWorkflow.php

View Options

src/workflow/ArcanistCoverWorkflow.php

View Options

src/workflow/ArcanistDiffWorkflow.php

View Options

src/workflow/ArcanistDownloadWorkflow.php

View Options

src/workflow/ArcanistExportWorkflow.php

View Options

src/workflow/ArcanistFeatureWorkflow.php

View Options

src/workflow/ArcanistFlagWorkflow.php

View Options

src/workflow/ArcanistGetConfigWorkflow.php

View Options

src/workflow/ArcanistHelpWorkflow.php

View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

View Options

src/workflow/ArcanistLandWorkflow.php

View Options

src/workflow/ArcanistLiberateWorkflow.php

View Options

src/workflow/ArcanistLintWorkflow.php

View Options

src/workflow/ArcanistLintersWorkflow.php

View Options

src/workflow/ArcanistListWorkflow.php

View Options

src/workflow/ArcanistPasteWorkflow.php

View Options

src/workflow/ArcanistPatchWorkflow.php

View Options

src/workflow/ArcanistRevertWorkflow.php

View Options

src/workflow/ArcanistSetConfigWorkflow.php

View Options

src/workflow/ArcanistShellCompleteWorkflow.php

View Options

src/workflow/ArcanistTasksWorkflow.php

View Options

src/workflow/ArcanistTodoWorkflow.php

View Options

src/workflow/ArcanistUnitWorkflow.php

View Options

src/workflow/ArcanistUpgradeWorkflow.php

View Options

src/workflow/ArcanistUploadWorkflow.php

View Options

src/workflow/ArcanistVersionWorkflow.php

View Options

src/workflow/ArcanistWhichWorkflow.php

View Options

src/workflow/ArcanistWorkflow.php

View Options

src/workflow/exception/ArcanistCapabilityNotSupportedException.php

View Options

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php

Phabricator · Built by Phacility