Paths

Table of Contentst

Differential D12598

Add a Go unit test engine with race detection (through go and godep).
AbandonedPublic
Actions

Authored by eMxyzptlk on Apr 28 2015, 7:34 PM.

Tags

None

Referenced Files

	F13146880: D12598.diff
	Fri, May 3, 10:49 AM

	F13135865: D12598.diff
	Thu, May 2, 11:07 AM

	Unknown Object (File)
	Tue, Apr 30, 1:10 AM

	Unknown Object (File)
	Sun, Apr 28, 6:03 AM

	Unknown Object (File)
	Thu, Apr 25, 12:45 AM

	Unknown Object (File)
	Thu, Apr 11, 8:35 AM

	Unknown Object (File)
	Wed, Apr 10, 1:57 AM

	Unknown Object (File)
	Mar 29 2024, 11:01 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6867: Add linter and unit test engine for Go(lang)

Summary

This Differential adds two new unit engines both are for Golang and both uses
ArcanistGoTestResultParser to parse the result. They run the tests with the -race flag.

Depends on D12537, D12546

Test Plan

Create a new repository with the following .arcconfig:

{
    "unit.engine": "GoTestRaceEngine"
}

Create arc_test.go

package test

import "testing"

func TestShouldNotPassRaceTest(t *testing.T) {
        var myString string

        go func() {
                myString = "hello"
        }()

        go func() {
                myString = "bye"
        }()
}

Now, run arc unit

Diff Detail

Repository

Branch

go-race-engine

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/unit/parser/__tests__/testresults/go.race-warning-test-case-failure-go1.4:27	TXT2	Tab Literal
Error	src/unit/parser/__tests__/testresults/go.race-warning-test-case-success-go1.4:28	TXT2	Tab Literal

Unit

Tests Passed

Build Status

Buildable 5572
Build 5591: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

eMxyzptlk updated this revision to Diff 30252.Apr 28 2015, 7:34 PM

eMxyzptlk retitled this revision from to Add a Go unit test engine with race detection (through go and godep)..

eMxyzptlk updated this object.

eMxyzptlk edited the test plan for this revision. (Show Details)

eMxyzptlk added a reviewer: Blessed Reviewers.

eMxyzptlk added parent revisions: D12546: Add support for the race detector in the parser, D12537: Add a Go unit test engine (through go and godep)..

eMxyzptlk added subscribers: epriestley, ox.

Herald edited edge metadata. · View Herald TranscriptApr 28 2015, 7:34 PM

D12546 is broken and must be fixed and merged here.

send the stderr before the stdout so we could parse the race condition
Merge branch 'go-unit-race-engine' into go-race-engine

joshuaspence added a subscriber: joshuaspence.Apr 29 2015, 4:29 AM

eMxyzptlk added a task: T6867: Add linter and unit test engine for Go(lang).Apr 30 2015, 1:41 AM

eMxyzptlk mentioned this in D12537: Add a Go unit test engine (through go and godep)..Apr 30 2015, 4:25 AM

eMxyzptlk mentioned this in D12621: Add a Go unit test engine with support for Race and Godep..Apr 30 2015, 10:37 AM

Closed in favor of D12621

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

10 lines

unit/

engine/

GoBaseTestEngine.php

54 lines

GoTestEngine.php

10 lines

GoTestRaceEngine.php

10 lines

GodepGoTestEngine.php

10 lines

GodepGoTestRaceEngine.php

10 lines

parser/

ArcanistGoTestResultParser.php

32 lines

__tests__/

ArcanistGoTestResultParserTestCase.php

41 lines

testresults/

go.race-warning-test-case-failure-go1.4

29 lines

go.race-warning-test-case-success-go1.4

28 lines

Diff 30252

src/__phutil_library_map__.php

Loading...

src/unit/engine/GoBaseTestEngine.php

Loading...

src/unit/engine/GoTestEngine.php

Loading...

src/unit/engine/GoTestRaceEngine.php

Loading...

src/unit/engine/GodepGoTestEngine.php

Loading...

src/unit/engine/GodepGoTestRaceEngine.php

Loading...

src/unit/parser/ArcanistGoTestResultParser.php

Loading...

src/unit/parser/tests/ArcanistGoTestResultParserTestCase.php

Loading...

src/unit/parser/tests/testresults/go.race-warning-test-case-failure-go1.4

Loading...

src/unit/parser/tests/testresults/go.race-warning-test-case-success-go1.4

Loading...