Paths

Table of Contentst

Differential D12526

Move ManiphestTaskQuery to EdgeLogic
ClosedPublic
Actions

Authored by epriestley on Apr 23 2015, 11:56 AM.

Tags

None

Referenced Files

	F14078036: D12526.diff
	Fri, Nov 22, 1:49 AM

	F14074487: D12526.diff
	Thu, Nov 21, 7:17 AM

	Unknown Object (File)
	Tue, Nov 19, 3:38 PM

	Unknown Object (File)
	Fri, Nov 15, 1:44 AM

	Unknown Object (File)
	Sun, Nov 10, 11:19 PM

	Unknown Object (File)
	Wed, Nov 6, 9:42 PM

	Unknown Object (File)
	Tue, Oct 29, 5:28 PM

	Unknown Object (File)
	Sun, Oct 27, 4:27 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T4100: Support query parameterization in typeaheads

Commits

Restricted Diffusion Commit
rP22e3e35418be: Move ManiphestTaskQuery to EdgeLogic

Summary

Ref T4100. Share all edge logic code across applications.

Internalizes the "check that the viewer can see projects" check into edge logic.
Adds some convenience functions. Some of these aren't really all that convenient, but it's rare that we actually apply project constraints to queries in the applications -- and most of these callsites will go away in the long term -- so I didn't go too crazy with providing a simpler withProjectPHIDs() universal API or anything.

Test Plan

Grepped for all affected symbols.
Tried to violate policies.
Used workboards.
Used normal Maniphest queries.
Used maniphest.query.
Verified the special grouping behavior works as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30072.Apr 23 2015, 11:56 AM

epriestley retitled this revision from to Move ManiphestTaskQuery to EdgeLogic.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4100: Support query parameterization in typeaheads.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 23 2015, 11:56 AM

epriestley added inline comments.Apr 23 2015, 12:08 PM

src/applications/home/controller/PhabricatorHomeMainController.php
182–186	In particular, this is a little bit cumbersome compared to the old API, but we only have about 6 callsites and half of them will vanish eventually, so it didn't seem worthwhile to define some convenience wrapper method to specify the project edge constant and/or operator for you.

btrahan accepted this revision.Apr 23 2015, 5:23 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 23 2015, 5:23 PM

Closed by commit rP22e3e35418be: Move ManiphestTaskQuery to EdgeLogic (authored by epriestley, committed by epriestley). · Explain WhyApr 23 2015, 6:50 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D12562: Remove unused ManiphestTaskOwner class.Apr 27 2015, 9:15 AM

joshuaspence mentioned this in rP44b17d0a9ace: Remove unused ManiphestTaskOwner class.May 3 2015, 12:08 AM

g-p-g mentioned this in T5051: Burn down charts for Milestones.May 5 2015, 11:26 AM

cburroughs mentioned this in D10610: A batch editable page for viewing a single board column.May 13 2015, 5:20 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

controller/

PhabricatorHomeMainController.php

5 lines

maniphest/

conduit/

ManiphestQueryConduitAPIMethod.php

5 lines

controller/

ManiphestReportController.php

5 lines

query/

ManiphestTaskQuery.php

225 lines

project/

controller/

PhabricatorProjectBoardViewController.php

6 lines

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

102 lines

Diff 30086

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...

src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php

Loading...

src/applications/maniphest/controller/ManiphestReportController.php

Loading...

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...