Paths

Table of Contentst

Differential D12473

Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter
ClosedPublic
Actions

Authored by joshuaspence on Apr 19 2015, 11:48 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCeb5621c99890: Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter

Summary

Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter so that it can be used within subclasses.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29930.Apr 19 2015, 11:48 PM

joshuaspence retitled this revision from to Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 19 2015, 11:48 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

• virendra20888 added a subscriber: • virendra20888.Apr 27 2015, 11:32 AM

epriestley accepted this revision.Apr 27 2015, 11:43 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 27 2015, 11:43 AM

Closed by commit rARCeb5621c99890: Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 3 2015, 12:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistBaseXHPASTLinter.php

14 lines

ArcanistXHPASTLinter.php

14 lines

Diff 30416

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php