Paths

Table of Contentst

Differential D12473

Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter
ClosedPublic
Actions

Authored by joshuaspence on Apr 19 2015, 11:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 3:14 AM

	Unknown Object (File)
	Mon, Nov 18, 8:43 AM

	Unknown Object (File)
	Sun, Nov 10, 3:42 AM

	Unknown Object (File)
	Sat, Nov 9, 4:48 AM

	Unknown Object (File)
	Sat, Nov 9, 4:13 AM

	Unknown Object (File)
	Wed, Nov 6, 10:05 AM

	Unknown Object (File)
	Fri, Nov 1, 7:13 AM

	Unknown Object (File)
	Oct 18 2024, 9:09 AM

Subscribers

• virendra20888

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCeb5621c99890: Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter

Summary

Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter so that it can be used within subclasses.

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5391
Build 5409: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,281 ms	ArcanistPuppetLintLinterTestCase::testLinter
	258 ms	ArcanistXMLLinterTestCase::testLinter
	884 ms	ArcanistCSSLintLinterTestCase::testLinter
	150 ms	ArcanistCSSLintLinterTestCase::testVersion
	137 ms	ArcanistChmodLinterTestCase::testLinter
		View Full Test Results (2 Failed · 47 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29930.Apr 19 2015, 11:48 PM

joshuaspence retitled this revision from to Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 19 2015, 11:48 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

• virendra20888 added a subscriber: • virendra20888.Apr 27 2015, 11:32 AM

epriestley accepted this revision.Apr 27 2015, 11:43 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 27 2015, 11:43 AM

Closed by commit rARCeb5621c99890: Move the getSuperGlobalNames method to ArcanistBaseXHPASTLinter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 3 2015, 12:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistBaseXHPASTLinter.php

14 lines

ArcanistXHPASTLinter.php

14 lines

Diff 29930

src/lint/linter/ArcanistBaseXHPASTLinter.php

Loading...

src/lint/linter/ArcanistXHPASTLinter.php

Loading...