Page MenuHomePhabricator
Differential D12472

Move the getFunctionCalls method to ArcanistBaseXHPASTLinter
ClosedPublic
Actions

Authored by joshuaspence on Apr 19 2015, 11:18 PM.
Tags
None
Referenced Files
F15526409: D12472.diff
Mon, Apr 21, 8:47 PM
F15519886: D12472.id31143.diff
Sun, Apr 20, 12:36 AM
F15505056: D12472.id29929.diff
Mon, Apr 14, 11:35 PM
F15486115: D12472.id31143.diff
Thu, Apr 10, 5:10 AM
F15483309: D12472.id.diff
Wed, Apr 9, 11:44 AM
F15482144: D12472.id31089.diff
Wed, Apr 9, 3:21 AM
F15480051: D12472.diff
Tue, Apr 8, 11:15 AM
F15452255: D12472.id.diff
Sat, Mar 29, 3:22 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC9862d7c0cb73: Move the getFunctionCalls method to ArcanistBaseXHPASTLinter
Summary

Move the getFunctionCalls method to the ArcanistBaseXHPASTLinter so that it can be used by subclasses.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29929.Apr 19 2015, 11:18 PM
joshuaspence retitled this revision from to Move the getFunctionCalls method to ArcanistBaseXHPASTLinter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 19 2015, 11:18 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 31089.May 19 2015, 11:41 AM
joshuaspence edited edge metadata.

Rebase

epriestley accepted this revision.May 19 2015, 3:13 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 3:13 PM
Closed by commit rARC9862d7c0cb73: Move the getFunctionCalls method to ArcanistBaseXHPASTLinter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31143

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php

Loading...
View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility