Paths

Table of Contentst

Differential D12472

Move the getFunctionCalls method to ArcanistBaseXHPASTLinter
ClosedPublic
Actions

Authored by joshuaspence on Apr 19 2015, 11:18 PM.

Tags

None

Referenced Files

	F13166524: D12472.diff
	Tue, May 7, 6:13 AM

	F13166328: D12472.diff
	Tue, May 7, 6:06 AM

	Unknown Object (File)
	Fri, May 3, 3:43 AM

	Unknown Object (File)
	Wed, May 1, 9:33 PM

	Unknown Object (File)
	Mon, Apr 29, 7:26 PM

	Unknown Object (File)
	Wed, Apr 24, 11:43 PM

	Unknown Object (File)
	Thu, Apr 11, 2:41 AM

	Unknown Object (File)
	Wed, Apr 10, 8:10 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC9862d7c0cb73: Move the getFunctionCalls method to ArcanistBaseXHPASTLinter

Summary

Move the getFunctionCalls method to the ArcanistBaseXHPASTLinter so that it can be used by subclasses.

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5390
Build 5408: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,129 ms	ArcanistPuppetLintLinterTestCase::testLinter
	940 ms	ArcanistCSSLintLinterTestCase::testLinter
	176 ms	ArcanistCSSLintLinterTestCase::testVersion
	143 ms	ArcanistChmodLinterTestCase::testLinter
	396 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 48 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29929.Apr 19 2015, 11:18 PM

joshuaspence retitled this revision from to Move the getFunctionCalls method to ArcanistBaseXHPASTLinter.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 19 2015, 11:18 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Rebase

epriestley accepted this revision.May 19 2015, 3:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 3:13 PM

Closed by commit rARC9862d7c0cb73: Move the getFunctionCalls method to ArcanistBaseXHPASTLinter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistBaseXHPASTLinter.php

29 lines

ArcanistPhutilXHPASTLinter.php

114 lines

ArcanistXHPASTLinter.php

26 lines

Diff 29929

src/lint/linter/ArcanistBaseXHPASTLinter.php

Loading...

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...

src/lint/linter/ArcanistXHPASTLinter.php

Loading...