Page MenuHomePhabricator
Differential D12472

Move the getFunctionCalls method to ArcanistBaseXHPASTLinter
ClosedPublic
Actions

Authored by joshuaspence on Apr 19 2015, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 4:28 PM
Unknown Object (File)
Sat, Dec 14, 3:25 PM
Unknown Object (File)
Mon, Dec 2, 9:34 PM
Unknown Object (File)
Thu, Nov 28, 12:51 PM
Unknown Object (File)
Sun, Nov 24, 5:52 PM
Unknown Object (File)
Nov 24 2024, 6:30 AM
Unknown Object (File)
Nov 22 2024, 6:18 PM
Unknown Object (File)
Oct 24 2024, 3:40 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC9862d7c0cb73: Move the getFunctionCalls method to ArcanistBaseXHPASTLinter
Summary

Move the getFunctionCalls method to the ArcanistBaseXHPASTLinter so that it can be used by subclasses.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6106
Build 6126: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29929.Apr 19 2015, 11:18 PM
joshuaspence retitled this revision from to Move the getFunctionCalls method to ArcanistBaseXHPASTLinter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 19 2015, 11:18 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 31089.May 19 2015, 11:41 AM
joshuaspence edited edge metadata.

Rebase

epriestley accepted this revision.May 19 2015, 3:13 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 3:13 PM
Closed by commit rARC9862d7c0cb73: Move the getFunctionCalls method to ArcanistBaseXHPASTLinter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31089

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php

Loading...
View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility