Page MenuHomePhabricator
Differential D12463

Implement function-driven logical project queries in Differential
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 6:39 PM.
Tags
None
Referenced Files
F15197062: D12463.id29911.diff
Sat, Feb 22, 8:22 PM
F15196552: D12463.id29911.diff
Sat, Feb 22, 6:01 PM
F15196420: D12463.id29956.diff
Sat, Feb 22, 5:30 PM
Unknown Object (File)
Sat, Feb 8, 3:47 AM
Unknown Object (File)
Sat, Feb 8, 3:47 AM
Unknown Object (File)
Sat, Feb 8, 3:47 AM
Unknown Object (File)
Sat, Feb 1, 1:39 AM
Unknown Object (File)
Tue, Jan 28, 5:56 PM
View All Files
Subscribers
chad
epriestley
joshuaspence
Tokens
"Pterodactyl" token, awarded by joshuaspence.

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
T5595: Allow all applications to filter results by project
Commits
Restricted Diffusion Commit
rP4005bff56702: Implement function-driven logical project queries in Differential
Summary

Ref T4100. Ref T5595. This implements these fields in one mega-field:

  • Projects
  • Not in projects
  • In any project
  • Include results in no projects
  • In users' projects

Hopefully, this is a step in the right direction.

Test Plan

Screen_Shot_2015-04-18_at_11.38.05_AM.png (70×785 px, 18 KB)

Diff Detail

Repository
rP Phabricator
Branch
logic10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/query/DifferentialRevisionSearchEngine.php:49XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5376
Build 5394: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29911.Apr 18 2015, 6:39 PM
epriestley retitled this revision from to Implement function-driven logical project queries in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5595: Allow all applications to filter results by project, T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 6:39 PM
chad added a subscriber: chad.Apr 18 2015, 8:53 PM

itsawesome

joshuaspence awarded a token.Apr 18 2015, 11:13 PM
joshuaspence added a subscriber: joshuaspence.
btrahan accepted this revision.Apr 20 2015, 4:47 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:47 PM
Closed by commit rP4005bff56702: Implement function-driven logical project queries in Differential (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29911

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalAndDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalOrNotDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility