Page MenuHomePhabricator
Differential D12453

Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 2:38 PM.
Tags
None
Referenced Files
F14393580: D12453.id29895.largetrue.diff
Sun, Dec 22, 12:01 AM
Unknown Object (File)
Tue, Dec 3, 3:45 PM
Unknown Object (File)
Nov 1 2024, 5:46 PM
Unknown Object (File)
Oct 24 2024, 12:52 AM
Unknown Object (File)
Oct 19 2024, 12:16 PM
Unknown Object (File)
Oct 16 2024, 9:55 PM
Unknown Object (File)
Oct 15 2024, 8:36 AM
Unknown Object (File)
Oct 15 2024, 12:42 AM
View All Files
Subscribers
epriestley
hach-que
yelirekim

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
T5595: Allow all applications to filter results by project
Commits
Restricted Diffusion Commit
rPf5580c7a083e: Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery
Summary

Ref T4100. Ref T5595.

To support a unified "Projects:" query across all applications, a future diff is going to add a set of "Edge Logic" capabilities to PolicyAwareQuery which write the required SELECT, JOIN, WHERE, HAVING and GROUP clauses for you.

With the addition of "Edge Logic", we'll have three systems which may need to build components of query claues: ordering/paging, customfields/applicationsearch, and edge logic.

For most clauses, queries don't currently call into the parent explicitly to get default components. I want to move more query construction logic up the class tree so it can be shared.

For most methods, this isn't a problem, but many subclasses define a buildWhereClause(). Make all such definitions protected and consistent.

This causes no behavioral changes.

Test Plan

Ran arc unit --everything, which does a pretty through job of verifying this statically.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29895.Apr 18 2015, 2:38 PM
epriestley retitled this revision from to Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5595: Allow all applications to filter results by project, T4100: Support query parameterization in typeaheads.
Herald added subscribers: epriestley, hach-que, yelirekim. · View Herald TranscriptApr 18 2015, 2:38 PM
btrahan accepted this revision.Apr 20 2015, 3:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 3:58 PM
Closed by commit rPf5580c7a083e: Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 114 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
query/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
calendar/
query/
2 lines
chatlog/
query/
2 lines
2 lines
conduit/
query/
2 lines
2 lines
config/
query/
2 lines
conpherence/
query/
2 lines
2 lines
2 lines
2 lines
countdown/
query/
2 lines
daemon/
query/
2 lines
dashboard/
query/
2 lines
2 lines
differential/
query/
2 lines
2 lines
2 lines
2 lines
2 lines
diffusion/
query/
2 lines
7 lines
2 lines
2 lines
diviner/
query/
2 lines
2 lines
doorkeeper/
query/
2 lines
drydock/
query/
2 lines
2 lines
2 lines
2 lines
feed/
query/
2 lines
files/
query/
2 lines
2 lines
flag/
query/
2 lines
fund/
query/
2 lines
2 lines
harbormaster/
query/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
herald/
query/
2 lines
2 lines
legalpad/
query/
2 lines
2 lines
mailinglists/
query/
2 lines
metamta/
query/
2 lines
notification/
query/
2 lines
nuance/
query/
2 lines
2 lines
2 lines
2 lines
oauthserver/
query/
2 lines
2 lines
owners/
query/
2 lines
passphrase/
query/
2 lines
paste/
query/
2 lines
people/
query/
2 lines
2 lines
phame/
query/
2 lines
2 lines
phlux/
query/
2 lines
pholio/
query/
2 lines
2 lines
phortune/
query/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
phragment/
query/
2 lines
2 lines
2 lines
2 lines
phrequent/
query/
2 lines
ponder/
query/
2 lines
2 lines
project/
query/
2 lines
2 lines
2 lines
releeph/
query/
2 lines
2 lines
2 lines
repository/
query/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
search/
query/
2 lines
2 lines
slowvote/
query/
2 lines
tokens/
query/
2 lines
2 lines
transactions/
query/
2 lines
2 lines
infrastructure/
daemon/
workers/
query/
2 lines
7 lines
2 lines
edges/
query/
2 lines
query/
policy/
42 lines

Diff 29949

View Options

src/applications/almanac/query/AlmanacBindingQuery.php

View Options

src/applications/almanac/query/AlmanacDeviceQuery.php

View Options

src/applications/almanac/query/AlmanacInterfaceQuery.php

View Options

src/applications/almanac/query/AlmanacNetworkQuery.php

View Options

src/applications/almanac/query/AlmanacPropertyQuery.php

View Options

src/applications/almanac/query/AlmanacServiceQuery.php

View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

View Options

src/applications/chatlog/query/PhabricatorChatLogChannelQuery.php

View Options

src/applications/chatlog/query/PhabricatorChatLogQuery.php

View Options

src/applications/conduit/query/PhabricatorConduitLogQuery.php

View Options

src/applications/conduit/query/PhabricatorConduitTokenQuery.php

View Options

src/applications/config/query/PhabricatorConfigEntryQuery.php

View Options

src/applications/conpherence/query/ConpherenceFulltextQuery.php

View Options

src/applications/conpherence/query/ConpherenceParticipantCountQuery.php

View Options

src/applications/conpherence/query/ConpherenceParticipantQuery.php

View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

View Options

src/applications/countdown/query/PhabricatorCountdownQuery.php

View Options

src/applications/daemon/query/PhabricatorDaemonLogQuery.php

View Options

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

View Options

src/applications/dashboard/query/PhabricatorDashboardQuery.php

View Options

src/applications/differential/query/DifferentialChangesetQuery.php

View Options

src/applications/differential/query/DifferentialDiffQuery.php

View Options

src/applications/differential/query/DifferentialHunkQuery.php

View Options

src/applications/differential/query/DifferentialInlineCommentQuery.php

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

View Options

src/applications/diffusion/query/DiffusionLintCountQuery.php

View Options

src/applications/diffusion/query/DiffusionPathQuery.php

View Options

src/applications/diffusion/query/DiffusionSymbolQuery.php

View Options

src/applications/diviner/query/DivinerAtomQuery.php

View Options

src/applications/diviner/query/DivinerBookQuery.php

View Options

src/applications/doorkeeper/query/DoorkeeperExternalObjectQuery.php

View Options

src/applications/drydock/query/DrydockBlueprintQuery.php

View Options

src/applications/drydock/query/DrydockLeaseQuery.php

View Options

src/applications/drydock/query/DrydockLogQuery.php

View Options

src/applications/drydock/query/DrydockResourceQuery.php

View Options

src/applications/feed/query/PhabricatorFeedQuery.php

View Options

src/applications/files/query/PhabricatorFileChunkQuery.php

View Options

src/applications/files/query/PhabricatorFileQuery.php

View Options

src/applications/flag/query/PhabricatorFlagQuery.php

View Options

src/applications/fund/query/FundBackerQuery.php

View Options

src/applications/fund/query/FundInitiativeQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildArtifactQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildItemQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildLogQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildStepQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildableQuery.php

View Options

src/applications/herald/query/HeraldRuleQuery.php

View Options

src/applications/herald/query/HeraldTranscriptQuery.php

View Options

src/applications/legalpad/query/LegalpadDocumentQuery.php

View Options

src/applications/legalpad/query/LegalpadDocumentSignatureQuery.php

View Options

src/applications/mailinglists/query/PhabricatorMailingListQuery.php

View Options

src/applications/metamta/query/PhabricatorMetaMTAApplicationEmailQuery.php

View Options

src/applications/notification/query/PhabricatorNotificationQuery.php

View Options

src/applications/nuance/query/NuanceItemQuery.php

View Options

src/applications/nuance/query/NuanceQueueQuery.php

View Options

src/applications/nuance/query/NuanceRequestorQuery.php

View Options

src/applications/nuance/query/NuanceSourceQuery.php

View Options

src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php

View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientQuery.php

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

View Options

src/applications/passphrase/query/PassphraseCredentialQuery.php

View Options

src/applications/paste/query/PhabricatorPasteQuery.php

View Options

src/applications/people/query/PhabricatorPeopleLogQuery.php

View Options

src/applications/people/query/PhabricatorPeopleQuery.php

View Options

src/applications/phame/query/PhameBlogQuery.php

View Options

src/applications/phame/query/PhamePostQuery.php

View Options

src/applications/phlux/query/PhluxVariableQuery.php

View Options

src/applications/pholio/query/PholioImageQuery.php

View Options

src/applications/pholio/query/PholioMockQuery.php

View Options

src/applications/phortune/query/PhortuneAccountQuery.php

View Options

src/applications/phortune/query/PhortuneCartQuery.php

View Options

src/applications/phortune/query/PhortuneChargeQuery.php

View Options

src/applications/phortune/query/PhortuneMerchantQuery.php

View Options

src/applications/phortune/query/PhortunePaymentMethodQuery.php

View Options

src/applications/phortune/query/PhortunePaymentProviderConfigQuery.php

View Options

src/applications/phortune/query/PhortuneProductQuery.php

View Options

src/applications/phortune/query/PhortunePurchaseQuery.php

View Options

src/applications/phortune/query/PhortuneSubscriptionQuery.php

View Options

src/applications/phragment/query/PhragmentFragmentQuery.php

View Options

src/applications/phragment/query/PhragmentFragmentVersionQuery.php

View Options

src/applications/phragment/query/PhragmentSnapshotChildQuery.php

View Options

src/applications/phragment/query/PhragmentSnapshotQuery.php

View Options

src/applications/phrequent/query/PhrequentUserTimeQuery.php

View Options

src/applications/ponder/query/PonderAnswerQuery.php

View Options

src/applications/ponder/query/PonderQuestionQuery.php

View Options

src/applications/project/query/PhabricatorProjectColumnPositionQuery.php

View Options

src/applications/project/query/PhabricatorProjectColumnQuery.php

View Options

src/applications/project/query/PhabricatorProjectQuery.php

View Options

src/applications/releeph/query/ReleephBranchQuery.php

View Options

src/applications/releeph/query/ReleephProductQuery.php

View Options

src/applications/releeph/query/ReleephRequestQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryMirrorQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php

View Options

src/applications/search/query/PhabricatorNamedQueryQuery.php

View Options

src/applications/search/query/PhabricatorSavedQueryQuery.php

View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

View Options

src/applications/tokens/query/PhabricatorTokenCountQuery.php

View Options

src/applications/tokens/query/PhabricatorTokenGivenQuery.php

View Options

src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php

View Options

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerArchiveTaskQuery.php

View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php

View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

View Options

src/infrastructure/edges/query/PhabricatorEdgeQuery.php

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Phabricator · Built by Phacility