Explicitly check for supported VCS
ClosedPublic
Actions

Authored by joshuaspence on Jan 29 2015, 11:17 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCe4be03177810: Explicitly check for supported VCS

Summary

Instead of having an ArcanistWorkflow subclass explicitly throw an exception when run in an unsupported VCS, consolidate this code and move it to arcanist.php. In doing so, we lose some specificity in some of the error messages, but this otherwise feels cleaner. We could consider adding a getUnsupportedRevisionControlSystemMessage() method to provide a more tailored error message. Depends on D11604.

Test Plan

Ran arc bookmark in a git working copy:

Usage Exception: `arc bookmark` is only supported under hg.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4216
Build 4229: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27804.Jan 29 2015, 11:17 AM

joshuaspence retitled this revision from to Explicitly checking for supported VCS.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D11549: Indicate that `arc bookmark` is only supported on Mercurial.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 29 2015, 11:17 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence mentioned this in D11551: Explicitly checking for supported VCS.Feb 1 2015, 8:35 PM

joshuaspence updated this object.

joshuaspence edited edge metadata.

joshuaspence removed a parent revision: D11549: Indicate that `arc bookmark` is only supported on Mercurial.

joshuaspence added a parent revision: D11549: Indicate that `arc bookmark` is only supported on Mercurial.Feb 1 2015, 8:37 PM

joshuaspence updated this object.

joshuaspence updated this object.Feb 1 2015, 8:41 PM

joshuaspence added a parent revision: D11604: Change "any" to explicitly list revision control systems.

joshuaspence mentioned this in D11549: Indicate that `arc bookmark` is only supported on Mercurial.

joshuaspence removed a parent revision: D11549: Indicate that `arc bookmark` is only supported on Mercurial.Feb 1 2015, 8:54 PM

Merge in D11549

joshuaspence updated this object.Feb 1 2015, 8:56 PM

Minor change

joshuaspence mentioned this in D11552: Only allow `arc branch` to be used under `git`.Feb 2 2015, 7:20 AM

joshuaspence retitled this revision from Explicitly checking for supported VCS to Explicitly check for supported VCS.

It's very slightly unfortunate to lose the "land" -> "commit" hint, but I can add a getSuggestedAlternateCommandForRevisionControlSystem() or something later if users seem confused.

This revision is now accepted and ready to land.Feb 2 2015, 2:04 PM

Closed by commit rARCe4be03177810: Explicitly check for supported VCS (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 7:54 PM

This revision was automatically updated to reflect the committed changes.