Paths

Table of Contentst

Differential D11604

Change "any" to explicitly list revision control systems
ClosedPublic
Actions

Authored by joshuaspence on Feb 1 2015, 8:40 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC623df14ae50b: Change "any" to explicitly list revision control systems

Summary

Using array('any') to represent array('git', 'hg', 'svn') is a bit magical and leads to a lot of special-casing.

Test Plan

Verified that tab completion (ala ArcanistShellCompleteWorkflow) still worked.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27922.Feb 1 2015, 8:40 PM

joshuaspence retitled this revision from to Change "any" to explicitly list revision control systems.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 1 2015, 8:40 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D11550: Explicitly check for supported VCS.Feb 1 2015, 8:41 PM

joshuaspence updated this object.Feb 1 2015, 8:44 PM

joshuaspence edited edge metadata.

joshuaspence edited the test plan for this revision. (Show Details)Feb 1 2015, 8:54 PM

epriestley accepted this revision.Feb 2 2015, 4:11 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 2 2015, 4:11 AM

Closed by commit rARC623df14ae50b: Change "any" to explicitly list revision control systems (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 7:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistShellCompleteWorkflow.php

5 lines

ArcanistWorkflow.php

2 lines

Diff 27939

View Options

src/workflow/ArcanistShellCompleteWorkflow.php