Page MenuHomePhabricator

Explicitly checking for supported VCS
AbandonedPublic

Authored by joshuaspence on Jan 29 2015, 11:17 AM.
Tags
None
Referenced Files
F18620293: D11551.diff
Sep 15 2025, 4:47 AM
F18377215: D11551.diff
Aug 28 2025, 12:15 PM
F18376382: D11551.id27805.diff
Aug 28 2025, 11:07 AM
F18376009: D11551.diff
Aug 28 2025, 10:39 AM
F17615102: D11551.diff
Jul 9 2025, 1:16 PM
Unknown Object (File)
May 20 2025, 6:11 PM
Unknown Object (File)
May 7 2025, 10:34 PM
Unknown Object (File)
Apr 24 2025, 4:21 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Instead of having an ArcanistWorkflow explicitly throw an exception when run in an unsupported VCS, consolidate this code and move it to arcanist.php. In doing so, we lose some specificity in some of the error messages, but this otherwise feels cleaner. We could consider adding a getUnsupportedRevisionControlSystemMessage() function to provide a more tailored error message. Depends on D11549

Test Plan

Ran arc bookmark in a git working copy:

Usage Exception: `arc bookmark` is only supported under hg.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4145
Build 4158: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Explicitly checking for supported VCS.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.