Page MenuHomePhabricator

Explicitly checking for supported VCS
AbandonedPublic

Authored by joshuaspence on Jan 29 2015, 11:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 4:22 AM
Unknown Object (File)
Thu, Dec 26, 4:55 AM
Unknown Object (File)
Tue, Dec 10, 3:14 PM
Unknown Object (File)
Fri, Dec 6, 5:50 AM
Unknown Object (File)
Dec 4 2024, 12:25 PM
Unknown Object (File)
Nov 27 2024, 5:47 AM
Unknown Object (File)
Nov 26 2024, 2:59 AM
Unknown Object (File)
Nov 23 2024, 8:25 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Instead of having an ArcanistWorkflow explicitly throw an exception when run in an unsupported VCS, consolidate this code and move it to arcanist.php. In doing so, we lose some specificity in some of the error messages, but this otherwise feels cleaner. We could consider adding a getUnsupportedRevisionControlSystemMessage() function to provide a more tailored error message. Depends on D11549

Test Plan

Ran arc bookmark in a git working copy:

Usage Exception: `arc bookmark` is only supported under hg.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4145
Build 4158: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Explicitly checking for supported VCS.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.