Paths

Table of Contentst

Fix XHPAST unit tests
AbandonedPublic
Actions

Authored by joshuaspence on Jan 7 2015, 8:47 PM.

Details

Reviewers

epriestley
richardvanvelzen

Group Reviewers

Blessed Reviewers

Summary

I think that these were broken by D11268.

Test Plan

arc unit -- src/parser/xhpast/

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3668
Build 3678: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27076.Jan 7 2015, 8:47 PM

joshuaspence retitled this revision from to Fix XHPAST unit tests.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, richardvanvelzen.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 7 2015, 8:47 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Hmm, the tests fail for me with these changes applied but pass at HEAD. Not sure what's out of sync on whose machine. Did you rebuild xhpast?

Hmm, yes. It seems that I am up-to-date:

> ./support/xhpast/xhpast -v
xhpast version 5.5.8/1g

Nevermind, I am an idiot.

haha

I was getting worried that this was some spooky ghost stuff

iiam

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-access-on-instanciation.expect

1282 lines

php-syntax.php.expect

22178 lines

php-traits.php.expect

1812 lines

Diff 27076

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

View Options

src/parser/xhpast/tests/data/php-syntax.php.expect

View Options

src/parser/xhpast/tests/data/php-traits.php.expect

Fix XHPAST unit testsAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27076

src/parser/xhpast/__tests__/data/php-access-on-instanciation.expect

src/parser/xhpast/__tests__/data/php-syntax.php.expect

src/parser/xhpast/__tests__/data/php-traits.php.expect

Fix XHPAST unit tests
AbandonedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

src/parser/xhpast/tests/data/php-syntax.php.expect

src/parser/xhpast/tests/data/php-traits.php.expect